Skip to content

Conversation

@joegallo
Copy link
Contributor

It's not actually the case that all the primaries need to be on the same node, replicas are sufficient. I think this got switched to the incorrect wording in #59985 -- so the docs should be fixed back to 7.8 branch if we're doing a completion run.

It's not actually the case that all the primaries need to be on the same node, replicas are sufficient.
from before the mistaken wording was added.
@joegallo joegallo added >docs General docs changes :Data Management/Indices APIs APIs to create and manage indices and templates v8.1.0 v7.17.1 v8.0.1 v8.2.0 labels Feb 21, 2022
@joegallo joegallo requested a review from jrodewig February 21, 2022 16:03
@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:Data Management Meta label for data/management team labels Feb 21, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @joegallo. Let me know if you need any help backporting this fix.

@joegallo joegallo merged commit 119fbcf into elastic:master Feb 21, 2022
@joegallo joegallo deleted the reword-shrink-docs branch February 21, 2022 21:17
joegallo added a commit that referenced this pull request Feb 21, 2022
joegallo added a commit that referenced this pull request Feb 21, 2022
joegallo added a commit that referenced this pull request Feb 21, 2022
@joegallo
Copy link
Contributor Author

@jrodewig I backported as far as 7.17 -- do you have tooling to make this easier for the older branches, or are you manually cherry-picking and pushing? Also what's the etiquette on PR labels for those older branches/backports?

If it's as simple as "yeah, indeed, add a label for all those versions, then cherry-pick and push" then I can just do that.

@jrodewig
Copy link
Contributor

jrodewig commented Feb 21, 2022

do you have tooling to make this easier for the older branches, or are you manually cherry-picking and pushing?

I use the backport tool and temporarily edit .backportrc.json to add the missing branches. Cherry-picking and pushing should work fine too.

what's the etiquette on PR labels for those older branches/backports?

We add a label for those versions.

@joegallo
Copy link
Contributor Author

👍, all good, I can handle that then. Thanks!

joegallo added a commit that referenced this pull request Feb 22, 2022
joegallo added a commit that referenced this pull request Feb 22, 2022
joegallo added a commit that referenced this pull request Feb 22, 2022
joegallo added a commit that referenced this pull request Feb 22, 2022
joegallo added a commit that referenced this pull request Feb 22, 2022
joegallo added a commit that referenced this pull request Feb 22, 2022
joegallo added a commit that referenced this pull request Feb 22, 2022
joegallo added a commit that referenced this pull request Feb 22, 2022
joegallo added a commit that referenced this pull request Feb 22, 2022
probakowski pushed a commit to probakowski/elasticsearch that referenced this pull request Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants