Fix clone API settings docs bug #74175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
In elastic#74138 we noted that index settings aren't copied in a clone. In fact that's not true, we copy everything except explicitly-excluded ones, `number_of_replicas` and `auto_expand_replicas`. This fixes the mistake.
DaveCTurner added >docs 
elasticmachine added Team:Data Management 
Collaborator
| Pinging @elastic/es-docs (Team:Docs) |
Collaborator
| Pinging @elastic/es-core-features (Team:Core/Features) |
jrodewig approved these changes Jun 16, 2021
Contributor
jrodewig left a comment
jrodewig left a comment There was a problem hiding this comment.
I pushed a minor fix to the formatting. Otherwise LGTM. Thanks for fixing this @DaveCTurner.
DaveCTurner added a commit that referenced this pull request Jun 16, 2021
In #74138 we noted that index settings aren't copied in a clone. In fact that's not true, we copy everything except explicitly-excluded ones, `number_of_replicas` and `auto_expand_replicas`. This fixes the mistake. Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
DaveCTurner added a commit that referenced this pull request Jun 16, 2021
In #74138 we noted that index settings aren't copied in a clone. In fact that's not true, we copy everything except explicitly-excluded ones, `number_of_replicas` and `auto_expand_replicas`. This fixes the mistake. Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
limingnihao pushed a commit to limingnihao/elasticsearch that referenced this pull request Jun 17, 2021
* master: (284 commits) [DOCS] Update central reporting image (elastic#74195) [DOCS] SQL: Document `null` handing for string functions (elastic#74201) Fix Snapshot Docs Listing Query Params in Body Incorrectly (elastic#74196) [DOCS] EQL: Note EQL uses `fields` parameter (elastic#74194) Mute failing MixedClusterClientYamlTestSuiteIT test {p0=indices.split/20_source_mapping/Split index ignores target template mapping} test (elastic#74198) Cleanup Duplicate Constants in Snapshot XContent Params (elastic#74114) [DOC] Add watcher to the threadpool doc (elastic#73935) [Rest Api Compatibility] Validate Query typed api (elastic#74171) Replace deprecated `script.cache.*` settings with `script.context.$constext.cache_*` in documentation. (elastic#74144) Pin Alpine Linux version in Docker builds (elastic#74169) Fix clone API settings docs bug (elastic#74175) [ML] refactor internal datafeed management (elastic#74018) Disable query cache for FunctionScoreQuery and ScriptScoreQuery (elastic#74060) Fork the sending of file chunks during recovery (elastic#74164) RuntimeField.Builder should not extend FieldMapper.Builder (elastic#73840) Run CheckIndex on metadata index before loading (elastic#73239) Deprecate setting version on analyzers (elastic#74073) Add test with null transform id in stats request (elastic#74130) Order imports when reformatting (elastic#74059) Move deprecation code from xpack core to deprecation module. (elastic#74120) ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In #74138 we noted that index settings aren't copied in a clone. In fact
that's not true, we copy everything except explicitly-excluded ones,
number_of_replicasandauto_expand_replicas. This fixes the mistake.