Use default application credentials for GCS repositories #71239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ywelsch added :Distributed Coordination/Snapshot/Restore 
dliappis reviewed Apr 6, 2021
| | ||
| @SuppressForbidden(reason = "ok to open connection here") | ||
| private static String getDefaultProjectId() throws IOException { | ||
| String metaHost = System.getenv("GCE_METADATA_HOST"); |
There was a problem hiding this comment.
I was wondering if there is ever a case where the metadata server is not metadata.google.internal, but I suppose a) there is no guarantee this will remain for ever the same b) it might be useful esp. under additional layers under k8s etc.
There was a problem hiding this comment.
This is purely used for testing. While the Google library uses this environment variable in other places (e.g. to load the credentials from the environment) it does not check it when loading the project id :/
elasticmachine added the Team:Distributed (Obsolete) 
| Pinging @elastic/es-distributed (Team:Distributed) |
tlrx approved these changes Apr 6, 2021
...pository-gcs/src/main/java/org/elasticsearch/repositories/gcs/GoogleCloudStorageService.java Show resolved Hide resolved
...pository-gcs/src/main/java/org/elasticsearch/repositories/gcs/GoogleCloudStorageService.java Show resolved Hide resolved
test/fixtures/gcs-fixture/src/main/java/fixture/gcs/GoogleCloudStorageHttpHandler.java Show resolved Hide resolved
ywelsch added a commit that referenced this pull request Apr 6, 2021
Adds support for "Default Application Credentials" for GCS repositories, making it easier to set up a repository on GCP, as all relevant information to connect to the repository is retrieved from the environment, not necessitating complicated keystore setups.
ghost mentioned this pull request 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Adds support for Default Application Credentials for GCS repositories, making it easier to set up a repository on GCP, as all relevant information to connect to the repository is retrieved from the environment, not necessitating complicated keystore setups.