Filter empty fields in SearchHit#toXContent #58418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This commit restores the filtering of empty fields during the xcontent serialization of SearchHit. The filtering was removed unintentionally in elastic#41656.
jimczi added >bug >regression :Search/Search 
Collaborator
| Pinging @elastic/es-search (:Search/Search) |
cbuescher reviewed Jun 23, 2020
Member
cbuescher left a comment
cbuescher left a comment There was a problem hiding this comment.
Looks good, I left a small comment around testing.
mayya-sharipova approved these changes Jun 24, 2020
Contributor
mayya-sharipova left a comment
mayya-sharipova left a comment There was a problem hiding this comment.
@jimczi Thanks for this PR. Sorry that I missed that before.
jimczi added a commit that referenced this pull request Jun 25, 2020
This commit restores the filtering of empty fields during the xcontent serialization of SearchHit. The filtering was removed unintentionally in #41656.
jimczi added a commit that referenced this pull request Jun 25, 2020
This commit restores the filtering of empty fields during the xcontent serialization of SearchHit. The filtering was removed unintentionally in #41656.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This commit restores the filtering of empty fields during the
xcontent serialization of SearchHit. The filtering was removed
unintentionally in #41656.