has_parent builder: exception message/param fix #31182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
colings86 added the :Search/Search 
Collaborator
| Pinging @elastic/es-search-aggs |
jtibshirani reviewed Jun 29, 2018
Contributor
jtibshirani left a comment
jtibshirani left a comment There was a problem hiding this comment.
Thanks @nirmalc for the fix! I left a small comment.
Contributor
There was a problem hiding this comment.
To avoid this getting out-of-sync in the future, it would be nice to use PARENT_TYPE_FIELD.getPreferredName() instead of hard-coding parent_type. The same idea applies to query below.
has_parent builder throws exception message that it expects a `type` while parser excepts `parent_type`
nirmalc force-pushed the has_parentExceptionMessage branch from 4aa0e42 to 870a90f Compare 
Contributor Author
| Thanks for review, I've updated and rebased with latest master |
Contributor
| @elasticmachine test this please |
jasontedor added a commit to martijnvg/elasticsearch that referenced this pull request Jul 1, 2018
* elastic/ccr: (30 commits) Enable setting client path prefix to / (elastic#30119) [DOCS] Secure settings specified per node (elastic#31621) has_parent builder: exception message/param fix (elastic#31182) TEST: Randomize soft-deletes settings (elastic#31585) Mute 'Test typed keys parameter for suggesters' as we await a fix. Build test: Thread linger Fix gradle4.8 deprecation warnings (elastic#31654) Mute FileRealmTests#testAuthenticateCaching with an @AwaitsFix. Mute TransportChangePasswordActionTests#testIncorrectPasswordHashingAlgorithm with an @AwaitsFix. Build: Fix naming conventions task (elastic#31681) Introduce a Hashing Processor (elastic#31087) Do not check for object existence when deleting repository index files (elastic#31680) Remove extra check for object existence in repository-gcs read object (elastic#31661) Support multiple system store types (elastic#31650) [Test] Clean up some repository-s3 tests (elastic#31601) [Docs] Use capital letters in section headings (elastic#31678) muted tests that will be replaced by the shard follow task refactoring: elastic#31581 [DOCS] Add PQL language Plugin (elastic#31237) Merge AzureStorageService and AzureStorageServiceImpl and clean up tests (elastic#31607) TEST: Fix test task invocation (elastic#31657) ...
jimczi pushed a commit that referenced this pull request Nov 9, 2018
has_parent builder throws exception message that it expects a `type` while parser excepts `parent_type`
jimczi pushed a commit that referenced this pull request Nov 9, 2018
has_parent builder throws exception message that it expects a `type` while parser excepts `parent_type`
Contributor
| The issue is still on 6x so I pushed the fix for this version (also in 6.5.1). |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
has_parent builder throws exception message that it expects a
typewhile parser excepts
parent_type