Skip to content

Missing _source in other example #25743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2017
Merged

Missing _source in other example #25743

merged 1 commit into from
Jul 17, 2017

Conversation

@GlenRSmith
Copy link
Contributor

@GlenRSmith GlenRSmith commented Jul 17, 2017

(I ought to have done this in my last PR. Mea culpa.)

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS that we support?
  • If you are submitting this code for a class then read our policy for that.
@GlenRSmith
Missing _source in other example
812ca7e 
(I ought to have done this in my last PR. Mea culpa.)
jasontedor
jasontedor approved these changes Jul 17, 2017
View reviewed changes
Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@jasontedor jasontedor merged commit e9dfb2a into master Jul 17, 2017
jasontedor pushed a commit that referenced this pull request Jul 17, 2017
@GlenRSmith @jasontedor
Fix another simulate example in ingest docs
4b26c0e 
When simulating an ingest pipeline against an existing pipeline, the _source field is required to wrap each doc. This commit fixes another example in the docs that is missing this. Relates #25743, relates 8d314dd
jasontedor pushed a commit that referenced this pull request Jul 17, 2017
@GlenRSmith @jasontedor
Fix another simulate example in ingest docs
087f745 
When simulating an ingest pipeline against an existing pipeline, the _source field is required to wrap each doc. This commit fixes another example in the docs that is missing this. Relates #25743, relates 84e854d
@jasontedor jasontedor deleted the GlenRSmith-patch-3-1 branch July 17, 2017 06:19
@clintongormley clintongormley added the >docs General docs changes label Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>docs General docs changes

4 participants

@GlenRSmith @jasontedor @clintongormley