Mappings: Enforce metadata fields are not passed in documents #14003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
We previously removed the ability to specify metadata fields inside documents in elastic#11074, but the backcompat left leniency that allowed this to still occur. This change locks down parsing so any metadata field found while parsing a document results in an exception. This only affects 2.0+ indexes; backcompat is maintained. closes elastic#13740
rjernst added >bug :Search Foundations/Mapping 
Contributor
| LGTM |
rjernst added a commit that referenced this pull request Oct 7, 2015
Mappings: Enforce metadata fields are not passed in documents
rjernst added a commit that referenced this pull request Oct 7, 2015
Mappings: Enforce metadata fields are not passed in documents
rjernst added a commit that referenced this pull request Oct 7, 2015
Mappings: Enforce metadata fields are not passed in documents
rjernst added a commit that referenced this pull request Oct 7, 2015
Mappings: Enforce metadata fields are not passed in documents
This was referenced Oct 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We previously removed the ability to specify metadata fields inside
documents in #11074, but the backcompat left leniency that allowed this
to still occur. This change locks down parsing so any metadata field
found while parsing a document results in an exception. This only
affects 2.0+ indexes; backcompat is maintained.
closes #13740
closes #3517