Skip to content

Conversation

jdconrad
Copy link
Contributor

This has an unusual case where we took a dead primary id and combined it with a patch only id for a change that removed a boolean in 8.19. This worked because the primary id was created prior to the 9.1.0 release, so this still guarantees compatibility with all upgrade paths.

ES-12334

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

var transportVersion = in.getTransportVersion();
return (transportVersion.onOrAfter(TransportVersions.ESQL_REGEX_MATCH_WITH_CASE_INSENSITIVITY)
|| transportVersion.isPatchFrom(TransportVersions.ESQL_REGEX_MATCH_WITH_CASE_INSENSITIVITY_8_19)) && in.readBoolean();
return (transportVersion.supports(ESQL_REGEX_MATCH_WITH_CASE_INSENSITIVITY)) && in.readBoolean();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the parents aren't needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@jdconrad jdconrad merged commit fa41b6e into elastic:main Sep 26, 2025
33 checks passed
jdconrad added a commit to jdconrad/elasticsearch that referenced this pull request Sep 26, 2025
This has an unusual case where we took a dead primary id and combined it with a patch only id for a change that removed a boolean in 8.19. This worked because the primary id was created prior to the 9.1.0 release, so this still guarantees compatibility with all upgrade paths. ES-12334
jdconrad added a commit to jdconrad/elasticsearch that referenced this pull request Sep 26, 2025
This has an unusual case where we took a dead primary id and combined it with a patch only id for a change that removed a boolean in 8.19. This worked because the primary id was created prior to the 9.1.0 release, so this still guarantees compatibility with all upgrade paths. ES-12334
elasticsearchmachine pushed a commit that referenced this pull request Sep 26, 2025
Backports the following commits to 9.1: - Migrate transport versions 8841050 through 8841041 (#135555)
szybia added a commit to szybia/elasticsearch that referenced this pull request Sep 29, 2025
* upstream/main: (22 commits) Fix InternalCategorizationAggregationTests.testReduceRandom (elastic#135533) [DOCS] GeoIP processor: add clarification about using a reverse proxy endpoint (elastic#135534) Move `ProjectRoutingInfo` and related classes (elastic#135586) Refactor IndexAbstractionResolver (elastic#135587) Simplify returnLocalAll handling in ES|QL (elastic#135353) Reapply "Add an option to return early from an allocate call" (elastic#135589) Mute org.elasticsearch.xpack.esql.qa.single_node.GenerativeIT test elastic#134407 Mute org.elasticsearch.xpack.esql.heap_attack.HeapAttackIT testAggTooManyMvLongs elastic#135585 Mute org.elasticsearch.multiproject.test.XpackWithMultipleProjectsClientYamlTestSuiteIT test {yaml=esql/60_usage/Basic ESQL usage output (telemetry) snapshot version} elastic#135579 Mute org.elasticsearch.search.ccs.KnnVectorQueryBuilderCrossClusterSearchIT testKnnQueryWithCcsMinimizeRoundTripsFalse elastic#135573 Mute org.elasticsearch.xpack.esql.inference.textembedding.TextEmbeddingOperatorTests testSimpleCircuitBreaking elastic#135569 Add telemetry for `TS` command (elastic#135471) Mute org.elasticsearch.cluster.routing.allocation.decider.RestoreInProgressAllocationDeciderTests testCanAllocatePrimaryExistingInRestoreInProgress elastic#135566 allocation: clarify RestoreInProgressAllocationDecider failure message (elastic#132307) [ES|QL] Register AggregateMetricDoubleLiteral (elastic#135054) Validate Logstash pipeline ID when creating. (elastic#135378) Migrate transport versions 8841050 through 8841041 (elastic#135555) Mute org.elasticsearch.search.ccs.SparseVectorQueryBuilderCrossClusterSearchIT testSparseVectorQueryWithCcsMinimizeRoundTripsFalse elastic#135559 Mute org.elasticsearch.action.admin.cluster.stats.SearchUsageStatsTests testToXContent elastic#135558 Testing indices query cache memory stats (elastic#135298) ...
elasticsearchmachine pushed a commit that referenced this pull request Sep 29, 2025
…135562) Backports the following commits to 8.19: - Migrate transport versions 8841050 through 8841041 (#135555)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment