Skip to content

[9.0] [ML] Fix double-counting of inference memory in the assignment rebalancer (#133919) #134052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2025
+6 −7
Merged

[9.0] [ML] Fix double-counting of inference memory in the assignment rebalancer (#133919) #134052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/133919.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 133919
summary: Fix double-counting of inference memory in the assignment rebalancer
area: Machine Learning
type: bug
issues: []
8 changes: 1 addition & 7 deletions ...ava/org/elasticsearch/xpack/ml/inference/assignment/TrainedModelAssignmentRebalancer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,9 +303,7 @@ private Map<List<String>, List<AssignmentPlan.Node>> createNodesByZoneMap() {
nodes.add(
new AssignmentPlan.Node(
discoveryNode.getId(),
// We subtract native inference memory as the planner expects available memory for
// native inference including current assignments.
getNodeFreeMemoryExcludingPerNodeOverheadAndNativeInference(load),
load.getFreeMemoryExcludingPerNodeOverhead(),
MlProcessors.get(discoveryNode, allocatedProcessorsScale).roundUp()
)
);
Expand All @@ -322,10 +320,6 @@ private Map<List<String>, List<AssignmentPlan.Node>> createNodesByZoneMap() {
}));
}

private static long getNodeFreeMemoryExcludingPerNodeOverheadAndNativeInference(NodeLoad load) {
return load.getFreeMemoryExcludingPerNodeOverhead() - load.getAssignedNativeInferenceMemory();
}

private TrainedModelAssignmentMetadata.Builder buildAssignmentsFromPlan(AssignmentPlan assignmentPlan) {
TrainedModelAssignmentMetadata.Builder builder = TrainedModelAssignmentMetadata.Builder.empty();
for (AssignmentPlan.Deployment deployment : assignmentPlan.deployments()) {
Expand Down