Refactor: Add RewriteableAware interface for functions that require r… #133075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
kderusso commented Aug 18, 2025
| if (expr instanceof RewriteableAware rewriteableAware) { | ||
| QueryBuilder builder = rewriteableAware.queryBuilder(), initial = builder; | ||
| builder = builder == null | ||
| ? rewriteableAware.asQuery(LucenePushdownPredicates.DEFAULT, TranslatorHandler.TRANSLATOR_HANDLER).toQueryBuilder() |
There was a problem hiding this comment.
The RewriteableAware interface implements TranslationAware to handle asQuery here.
kderusso commented Aug 18, 2025
...ain/java/org/elasticsearch/xpack/esql/expression/function/fulltext/QueryBuilderResolver.java Outdated Show resolved Hide resolved
elasticsearchmachine added the Team:Analytics 
| Pinging @elastic/es-analytical-engine (Team:Analytics) |
ioanatia reviewed Aug 19, 2025
...ain/java/org/elasticsearch/xpack/esql/expression/function/fulltext/QueryBuilderResolver.java Outdated Show resolved Hide resolved
...ain/java/org/elasticsearch/xpack/esql/expression/function/fulltext/QueryBuilderResolver.java Outdated Show resolved Hide resolved
ioanatia approved these changes Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We will be adding new functions that require rewriting but that are not full text functions.
This PR does some preliminary refactoring, to add a
RewriteableAwareinterface defining when a function needs to go through the rewrite phase.