Refactor TransportVersion loading to support external consumers #132694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jdconrad added :Core/Infra/Transport API 
| Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst approved these changes Aug 12, 2025
| String component, | ||
| String path, | ||
| Function<String, InputStream> nameToStream, | ||
| TriFunction<String, String, BufferedReader, T> parser |
There was a problem hiding this comment.
could this be a bespoke functional interface? it can be package private
jdconrad added a commit to jdconrad/elasticsearch that referenced this pull request Aug 13, 2025
…tic#132694) This change moves transport version loading out of TransportVersion.VersionsHolder, so that is can be consumed elsewhere by projects using the same resource file structure. Jira: ES-12401
💔 Backport failed
You can use sqren/backport to manually backport by running |
jdconrad added a commit to jdconrad/elasticsearch that referenced this pull request Aug 13, 2025
…tic#132694) This change moves transport version loading out of TransportVersion.VersionsHolder, so that is can be consumed elsewhere by projects using the same resource file structure. Jira: ES-12401
elasticsearchmachine pushed a commit that referenced this pull request Aug 13, 2025
) (#132830) This change moves transport version loading out of TransportVersion.VersionsHolder, so that is can be consumed elsewhere by projects using the same resource file structure. Jira: ES-12401
elasticsearchmachine pushed a commit that referenced this pull request Aug 13, 2025
) (#132831) This change moves transport version loading out of TransportVersion.VersionsHolder, so that is can be consumed elsewhere by projects using the same resource file structure. Jira: ES-12401
jdconrad added a commit to jdconrad/elasticsearch that referenced this pull request Aug 13, 2025
…tic#132694) This change moves transport version loading out of TransportVersion.VersionsHolder, so that is can be consumed elsewhere by projects using the same resource file structure. Jira: ES-12401
elasticsearchmachine pushed a commit that referenced this pull request Aug 13, 2025
) (#132862) This change moves transport version loading out of TransportVersion.VersionsHolder, so that is can be consumed elsewhere by projects using the same resource file structure. Jira: ES-12401
jdconrad added a commit to jdconrad/elasticsearch that referenced this pull request Aug 13, 2025
…tic#132694) (elastic#132862) This change moves transport version loading out of TransportVersion.VersionsHolder, so that is can be consumed elsewhere by projects using the same resource file structure. Jira: ES-12401
szybia added a commit to szybia/elasticsearch that referenced this pull request Aug 15, 2025
* upstream/8.19: (62 commits) Use consistent terminology for transport version resources/references (elastic#132882) (elastic#132898) Move inner records out of TransportVersionUtils (elastic#132872) (elastic#132886) Forward port release notes for v8.18.5 (elastic#132758) Add more transport version files validation (elastic#132373) (elastic#132777) Forward port release notes for v8.17.10 (elastic#132760) Refactor TransportVersion loading to support external consumers (elastic#132694) (elastic#132862) manual backporting| (elastic#132783) 9.1 docs backports for 8.19 features (elastic#132605) Migrate x-pack-deprecation REST tests (elastic#131444) (elastic#132802) Update 8.19.1.asciidoc (elastic#132755) Update wolfi (versioned) (elastic#132752) Update 8.19.0.asciidoc (elastic#132754) Prune changelogs after 8.19.2 release Bump versions after 8.19.2 release Finalize release notes for v8.19.2 Bump versions after 8.17.10 release Prune changelogs after 8.18.5 release Bump versions after 8.18.5 release Add release notes for v8.19.2 release (elastic#132696) [ML] Improve EIS auth call logs and fix revocation bug (elastic#132546) (elastic#132690) ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This change moves transport version loading out of
TransportVersion.VersionsHolder, so that is can be consumed elsewhere by projects using the same resource file structure.Jira: ES-12401