Calculate text string length correctly for code points outside BMP #132593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
elasticsearchmachine added needs:triage 
parkertimmins added auto-backport 
| Pinging @elastic/es-storage-engine (Team:StorageEngine) |
| Hi @parkertimmins, I've created a changelog YAML for you. |
jordan-powers approved these changes Aug 8, 2025
parkertimmins changed the title parkertimmins changed the title This was referenced Aug 8, 2025
💔 Backport failed
You can use sqren/backport to manually backport by running |
This was referenced Aug 8, 2025
parkertimmins added a commit to parkertimmins/elasticsearch that referenced this pull request Aug 8, 2025
…lastic#132593) Strings parsed with the optimized UTF8 parsing have their length calculated during parsing. This length should be the same as the length if the string is parsed with the non-optimized path. Specifically, characters outside the basic multilingual plane require 2 chars per code point in the UTF16 encoding. (cherry picked from commit fa6e905)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
parkertimmins added a commit to parkertimmins/elasticsearch that referenced this pull request Aug 8, 2025
…lastic#132593) Strings parsed with the optimized UTF8 parsing have their length calculated during parsing. This length should be the same as the length if the string is parsed with the non-optimized path. Specifically, characters outside the basic multilingual plane require 2 chars per code point in the UTF16 encoding. (cherry picked from commit fa6e905) # Conflicts: # muted-tests.yml
elasticsearchmachine pushed a commit that referenced this pull request Aug 8, 2025
…132593) (#132598) Strings parsed with the optimized UTF8 parsing have their length calculated during parsing. This length should be the same as the length if the string is parsed with the non-optimized path. Specifically, characters outside the basic multilingual plane require 2 chars per code point in the UTF16 encoding. (cherry picked from commit fa6e905)
elasticsearchmachine pushed a commit that referenced this pull request Aug 8, 2025
…132593) (#132599) Strings parsed with the optimized UTF8 parsing have their length calculated during parsing. This length should be the same as the length if the string is parsed with the non-optimized path. Specifically, characters outside the basic multilingual plane require 2 chars per code point in the UTF16 encoding. (cherry picked from commit fa6e905) # Conflicts: # muted-tests.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Strings parsed with the optimized UTF8 parsing have their length calculated during parsing. This length should be the same as the length if the string is parsed with the non-optimized path. Specifically, characters outside the basic multilingual plane require 2 chars per code point in the UTF16 encoding.