EQL: Deal with internally created IN in a different way for EQL #132167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Hi @astefan, I've created a changelog YAML for you. |
…into 118621_fix
astefan commented Jul 31, 2025
| api 'io.ous:jtoml:2.0.0' | ||
| } | ||
| | ||
| tasks.register("loadTestData", JavaExec) { |
There was a problem hiding this comment.
Just for testing purposes, has nothing to do with the actual fix.
astefan commented Jul 31, 2025
| return map; | ||
| } | ||
| | ||
| public static void main(String[] args) throws IOException { |
There was a problem hiding this comment.
Changes in this class are just for testing purposes, has nothing to do with the actual fix.
astefan commented Jul 31, 2025
| return super.resolveType(); | ||
| } | ||
| | ||
| public TypeResolution validateInTypes() { |
There was a problem hiding this comment.
I've added this one because I didn't want to change the resolveType method and to be able to call it from the optimizer rule.
astefan commented Jul 31, 2025
| // double check the validity of an internally created IN (like the one created here). EQL is one where the IN | ||
| // implementation is like this mechanism here has been specifically created for it | ||
| if (shouldValidateIn()) { | ||
| Expression.TypeResolution resolution = in.validateInTypes(); |
There was a problem hiding this comment.
The meat of the fix.
astefan commented Jul 31, 2025
| In in = (In) e; | ||
| assertEquals(fa, in.value()); | ||
| assertThat(in.list(), contains(ONE, TWO)); | ||
| assertCombineDisjunctionsToIn((rule) -> { |
There was a problem hiding this comment.
Existent test methods are now tested on both types of In (with and without validation) to prove the validation existence doesn't change anything in the existent logic.
astefan added the auto-backport 
elasticsearchmachine added the Team:Analytics | Pinging @elastic/es-analytical-engine (Team:Analytics) |
costin approved these changes Aug 1, 2025
This was referenced Aug 4, 2025
astefan added a commit to astefan/elasticsearch that referenced this pull request Aug 4, 2025
astefan added a commit to astefan/elasticsearch that referenced this pull request Aug 4, 2025
astefan added a commit to astefan/elasticsearch that referenced this pull request Aug 4, 2025
elasticsearchmachine pushed a commit that referenced this pull request Aug 4, 2025
elasticsearchmachine pushed a commit that referenced this pull request Aug 4, 2025
elasticsearchmachine pushed a commit that referenced this pull request Aug 4, 2025
elasticsearchmachine pushed a commit that referenced this pull request Aug 4, 2025
szybia added a commit to szybia/elasticsearch that referenced this pull request Aug 5, 2025
…cking * upstream/main: (26 commits) [Fleet] add privileges to `kibana_system` to read integrations data (elastic#132400) Add `TestEntitlementsRule` with support for dynamic entitled node paths for testing (elastic#132077) Reduce logging frequency for GCS per project clients (elastic#132429) Skip update/100_synthetic_source tests in yamlRestCompatTests (elastic#132296) Correct exception for missing nested path (elastic#132408) Fixing esql release tests elastic#132369 (elastic#132406) Adjust date docvalue formatting to return 4xx instead of 5xx (elastic#132414) Handle nested fields with the termvectors REST API in artificial docs (elastic#92568) Only collect bulk scored vectors when exceeding min competitive (elastic#132293) Fix release tests diskbbq update (elastic#132405) ESQL: Fix skipping of generative tests (elastic#132390) Short circuit failure handling in OIDC flow (elastic#130618) Small optimization in OptimizedScalarQuantizer by using mul instead of div (elastic#132397) Aggs: Add validation to Bucket script pipeline agg (elastic#132320) ESQL: Multiple parameters in ungrouped aggs (elastic#132375) ESQL: Explain test operators (elastic#132374) EQL: Deal with internally created IN in a different way for EQL (elastic#132167) Speed up hierarchical k-means by computing distances in bulk (elastic#132384) Reduce the number of fields per document (elastic#132322) Assert current thread in ESQL (elastic#132324) ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #118621