Skip to content

Conversation

albertzaharovits
Copy link
Contributor

@albertzaharovits albertzaharovits commented Jul 24, 2025

The index settings are randomized in the test, but this test suite doesn't work when indices have a custom data path.

Sample error trace from a failed test:

java.lang.AssertionError: /Users/albert/workspace/elasticsearch/server/build/testrun/internalClusterTest/nodesTemp/org.elasticsearch.index.engine.MergeWithLowDiskSpaceIT_CAE31EC8BE716D68-005/tempDir-002/node_t0-shared/ygJhEDydHZ/0/0qa6JpozREG01yj2RGSasQ/0/index not tracked and not translog	at __randomizedtesting.SeedInfo.seed([CAE31EC8BE716D68]:0)	at org.junit.Assert.fail(Assert.java:89)	at org.junit.Assert.assertTrue(Assert.java:42)	at org.elasticsearch.cluster.DiskUsageIntegTestCase$TestFileSystemProvider.getTestFileStore(DiskUsageIntegTestCase.java:233)	at org.elasticsearch.cluster.DiskUsageIntegTestCase$TestFileSystemProvider.getFileStore(DiskUsageIntegTestCase.java:217)	at java.base/java.nio.file.Files.getFileStore(Files.java:1372)	at org.apache.lucene.misc.store.DirectIODirectory.<init>(DirectIODirectory.java:121)	at org.elasticsearch.index.store.FsDirectoryFactory$HybridDirectory$1.<init>(FsDirectoryFactory.java:158)	at org.elasticsearch.index.store.FsDirectoryFactory$HybridDirectory.<init>(FsDirectoryFactory.java:158)	at org.elasticsearch.index.store.FsDirectoryFactory.newFSDirectory(FsDirectoryFactory.java:81)	at org.elasticsearch.index.store.FsDirectoryFactory.newDirectory(FsDirectoryFactory.java:63)	at org.elasticsearch.plugins.IndexStorePlugin$DirectoryFactory.newDirectory(IndexStorePlugin.java:59)	at org.elasticsearch.index.IndexService.createShard(IndexService.java:559)	at org.elasticsearch.indices.IndicesService.createShard(IndicesService.java:970)	at org.elasticsearch.indices.cluster.IndicesClusterStateService.createShardWhenLockAvailable(IndicesClusterStateService.java:784)	at org.elasticsearch.indices.cluster.IndicesClusterStateService.createShard(IndicesClusterStateService.java:719)	at org.elasticsearch.indices.cluster.IndicesClusterStateService.createOrUpdateShard(IndicesClusterStateService.java:640)	at org.elasticsearch.indices.cluster.IndicesClusterStateService.createIndicesAndUpdateShards(IndicesClusterStateService.java:631)	at org.elasticsearch.indices.cluster.IndicesClusterStateService.doApplyClusterState(IndicesClusterStateService.java:324)	at org.elasticsearch.indices.cluster.IndicesClusterStateService.applyClusterState(IndicesClusterStateService.java:278)	at org.elasticsearch.cluster.service.ClusterApplierService.callClusterStateAppliers(ClusterApplierService.java:572)	at org.elasticsearch.cluster.service.ClusterApplierService.callClusterStateAppliers(ClusterApplierService.java:558)	at org.elasticsearch.cluster.service.ClusterApplierService.applyChanges(ClusterApplierService.java:531)	at org.elasticsearch.cluster.service.ClusterApplierService.runTask(ClusterApplierService.java:460)	at org.elasticsearch.cluster.service.ClusterApplierService$UpdateTask.run(ClusterApplierService.java:159)	at org.elasticsearch.common.util.concurrent.ThreadContext$ContextPreservingRunnable.run(ThreadContext.java:1000)	at org.elasticsearch.common.util.concurrent.PrioritizedEsThreadPoolExecutor$TieBreakingPrioritizedRunnable.runAndClean(PrioritizedEsThreadPoolExecutor.java:218)	at org.elasticsearch.common.util.concurrent.PrioritizedEsThreadPoolExecutor$TieBreakingPrioritizedRunnable.run(PrioritizedEsThreadPoolExecutor.java:184)	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1095)	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:619)	at java.base/java.lang.Thread.run(Thread.java:1447) 

Closes #131789

@albertzaharovits albertzaharovits self-assigned this Jul 24, 2025
@albertzaharovits albertzaharovits added >test Issues or PRs that are addressing/adding tests :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. v9.2.0 labels Jul 24, 2025
@albertzaharovits albertzaharovits requested a review from lkts July 24, 2025 07:45
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Indexing Meta label for Distributed Indexing team label Jul 24, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing)

Copy link
Contributor

@BrianRothermich BrianRothermich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@albertzaharovits albertzaharovits merged commit 6bf55e4 into elastic:main Jul 28, 2025
33 checks passed
szybia added a commit to szybia/elasticsearch that referenced this pull request Jul 28, 2025
…-tracking * upstream/main: Fix MergeWithLowDiskSpaceIT testRelocationWhileForceMerging (elastic#131806) [ML] Prevent the trained model deployment memory estimation from double-counting allocations. (elastic#131990) ES|QL Assert current thread during query planning and execution (elastic#131807) Add ElasticsearchIndexDeletionPolicy and EngineConfig policy wrapper (elastic#130442) [TEST] Adds tests for ESTestCase randomSubset methods (elastic#131745) Simplify esql session (elastic#131925) Simplify EsqlExecution info serialization (elastic#131823) Add utility to check for project global block (elastic#131927) [DOCS] Update ES|QL applies to's (elastic#131805) Handle structured log messages (elastic#131027) Mute org.elasticsearch.test.rest.yaml.RcsCcsCommonYamlTestSuiteIT test {p0=search/600_flattened_ignore_above/flattened ignore_above multi-value field} elastic#131967 Mute org.elasticsearch.xpack.remotecluster.CrossClusterEsqlRCS2EnrichUnavailableRemotesIT testEsqlEnrichWithSkipUnavailable elastic#131965 Mute org.elasticsearch.xpack.restart.FullClusterRestartIT testWatcherWithApiKey {cluster=UPGRADED} elastic#131964 [ES|QL] Fix aggregate_metric_double sorting and mv_expand issues (elastic#131658) Reduce logging levels for meter usage tests (elastic#131935)
@albertzaharovits albertzaharovits deleted the fix-131789 branch July 28, 2025 12:19
albertzaharovits added a commit to albertzaharovits/elasticsearch that referenced this pull request Jul 28, 2025
…131806) The index settings are randomized in the test, but this test suite doesn't work when indices have a custom data path.
albertzaharovits added a commit to albertzaharovits/elasticsearch that referenced this pull request Jul 28, 2025
…131806) The index settings are randomized in the test, but this test suite doesn't work when indices have a custom data path.
albertzaharovits added a commit to albertzaharovits/elasticsearch that referenced this pull request Jul 28, 2025
…131806) The index settings are randomized in the test, but this test suite doesn't work when indices have a custom data path.
elasticsearchmachine pushed a commit that referenced this pull request Jul 28, 2025
#131767) (#131778) * Add TEST MergeWithLowDiskSpaceIT testRelocationWhileForceMerging (#131767) This adds a test that covers relocation for shards that are running a force merge. Relates #93503 * Fix MergeWithLowDiskSpaceIT testRelocationWhileForceMerging (#131806) The index settings are randomized in the test, but this test suite doesn't work when indices have a custom data path.
elasticsearchmachine pushed a commit that referenced this pull request Jul 28, 2025
#131767) (#131781) * Add TEST MergeWithLowDiskSpaceIT testRelocationWhileForceMerging (#131767) This adds a test that covers relocation for shards that are running a force merge. Relates #93503 * Fix MergeWithLowDiskSpaceIT testRelocationWhileForceMerging (#131806) The index settings are randomized in the test, but this test suite doesn't work when indices have a custom data path. * Fix compilation
elasticsearchmachine pushed a commit that referenced this pull request Jul 28, 2025
…ng (#131767) (#131779) * Add TEST MergeWithLowDiskSpaceIT testRelocationWhileForceMerging (#131767) This adds a test that covers relocation for shards that are running a force merge. Relates #93503 * Fix MergeWithLowDiskSpaceIT testRelocationWhileForceMerging (#131806) The index settings are randomized in the test, but this test suite doesn't work when indices have a custom data path. * Fix compilation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. Team:Distributed Indexing Meta label for Distributed Indexing team >test Issues or PRs that are addressing/adding tests v9.2.0

4 participants