Track & log when there is insufficient disk space available to execute merges #131711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
enqueued merge tasks
albertzaharovits added >enhancement :Distributed Indexing/Engine 
| Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
| Hi @albertzaharovits, I've created a changelog YAML for you. |
elasticsearchmachine added the Team:Distributed Indexing | Here is a sample heap dump: |
| assert super.lock.isHeldByCurrentThread(); | ||
| Tuple<MergeTask, Long> head = enqueuedByBudget.peek(); | ||
| if (head != null && head.v2() > availableBudget) { | ||
| LOGGER.warn("There are merge tasks enqueued but there's insufficient disk space available to execute them"); |
There was a problem hiding this comment.
These log messages will be printed every indices.merge.disk.check_interval (5 sec). That sounds Ok to you, right?
There was a problem hiding this comment.
Would it be useful to include the availableBudget and head.v2() values in the log message too?
There was a problem hiding this comment.
Agree, thanks for suggesting! Pushed: d334433
DaveCTurner reviewed Jul 23, 2025
| Thanks for looking, David! |
tlrx approved these changes Jul 23, 2025
| assert super.lock.isHeldByCurrentThread(); | ||
| Tuple<MergeTask, Long> head = enqueuedByBudget.peek(); | ||
| if (head != null && head.v2() > availableBudget) { | ||
| LOGGER.warn("There are merge tasks enqueued but there's insufficient disk space available to execute them"); |
There was a problem hiding this comment.
Would it be useful to include the availableBudget and head.v2() values in the log message too?
| Locale.ROOT, | ||
| "There are no merge tasks currently running, " | ||
| + "but there are [%d] enqueued ones that are blocked because of insufficient disk space", | ||
| enqueuedByBudget.size() |
There was a problem hiding this comment.
Similarly, would it be useful to have the availableBudget and head.v2() values in the log message here?
| messageBuilder.append( | ||
| "], and there are [" | ||
| + enqueuedByBudget.size() | ||
| + "] additional enqueued ones that are blocked because of insufficient disk space" |
| } | ||
| } | ||
| | ||
| void postBudgetUpdate() {}; |
There was a problem hiding this comment.
I would assert super.lock.isHeldByCurrentThread(); here too
albertzaharovits added auto-merge-without-approval This was referenced Jul 23, 2025
albertzaharovits added a commit to albertzaharovits/elasticsearch that referenced this pull request Jul 23, 2025
…e merges (elastic#131711) This goal of this PR is to record information about the available disk space at the time that merge tasks are scheduled (the info will show up in heap dumps). This should aid troubleshooting in cases where there are running merge tasks all while the available disk space on the node is below the watermark. In this case we should increase the threshold for scheduling merge tasks `indices.merge.disk.watermark.high`, and possibly consider implementing aborting already executing merges too. Relates elastic#88606 (comment)
albertzaharovits added a commit to albertzaharovits/elasticsearch that referenced this pull request Jul 23, 2025
…e merges (elastic#131711) This goal of this PR is to record information about the available disk space at the time that merge tasks are scheduled (the info will show up in heap dumps). This should aid troubleshooting in cases where there are running merge tasks all while the available disk space on the node is below the watermark. In this case we should increase the threshold for scheduling merge tasks `indices.merge.disk.watermark.high`, and possibly consider implementing aborting already executing merges too. Relates elastic#88606 (comment)
elasticsearchmachine pushed a commit that referenced this pull request Jul 23, 2025
…e merges (#131711) (#131772) This goal of this PR is to record information about the available disk space at the time that merge tasks are scheduled (the info will show up in heap dumps). This should aid troubleshooting in cases where there are running merge tasks all while the available disk space on the node is below the watermark. In this case we should increase the threshold for scheduling merge tasks `indices.merge.disk.watermark.high`, and possibly consider implementing aborting already executing merges too. Relates #88606 (comment)
elasticsearchmachine pushed a commit that referenced this pull request Jul 23, 2025
…e merges (#131711) (#131773) This goal of this PR is to record information about the available disk space at the time that merge tasks are scheduled (the info will show up in heap dumps). This should aid troubleshooting in cases where there are running merge tasks all while the available disk space on the node is below the watermark. In this case we should increase the threshold for scheduling merge tasks `indices.merge.disk.watermark.high`, and possibly consider implementing aborting already executing merges too. Relates #88606 (comment)
elasticsearchmachine pushed a commit that referenced this pull request Jul 23, 2025
…e merges (#131711) (#131774) This goal of this PR is to record information about the available disk space at the time that merge tasks are scheduled (the info will show up in heap dumps). This should aid troubleshooting in cases where there are running merge tasks all while the available disk space on the node is below the watermark. In this case we should increase the threshold for scheduling merge tasks `indices.merge.disk.watermark.high`, and possibly consider implementing aborting already executing merges too. Relates #88606 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This goal of this PR is to record information about the available disk space at the time that merge tasks are scheduled (the info will show up in heap dumps).
This should aid troubleshooting in cases where there are running merge tasks all while the available disk space on the node is below the watermark. In this case we should increase the threshold for scheduling merge tasks
indices.merge.disk.watermark.high, and possibly consider implementing aborting already executing merges too.Relates #88606 (comment)