Skip to content

Grant server read/write permissions on shared data path "path.shared_data". #131680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 23, 2025
Merged

Grant server read/write permissions on shared data path "path.shared_data". #131680

merged 3 commits into from
Jul 23, 2025

Conversation

mosche
Copy link
Contributor

@mosche mosche commented Jul 22, 2025

Grant server read/write permissions on missing shared data path "path.shared_data".
This setting is deprecated, but possibly still used. This surfaced when enabling entitlements in internalClusterTest.

Relates to ES-12447
@mosche mosche requested a review from a team as a code owner July 22, 2025 10:12
@mosche mosche added >bug :Core/Infra/Entitlements Entitlements infrastructure labels Jul 22, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)
@elasticsearchmachine elasticsearchmachine added Team:Core/Infra Meta label for core/infra team v9.2.0 labels Jul 22, 2025
@mosche mosche added auto-backport Automatically create backport pull requests when merged v9.0.2 v9.1.1 v8.19.1 v9.0.5 v8.18.5 and removed Team:Core/Infra Meta label for core/infra team v9.2.0 labels Jul 22, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Jul 22, 2025
@elasticsearchmachine
Copy link
Collaborator

Hi @mosche, I've created a changelog YAML for you.
@mosche mosche force-pushed the entitlements/shared_data_path branch from ef543ec to b681afe Compare July 22, 2025 11:02
rjernst
rjernst approved these changes Jul 22, 2025
View reviewed changes
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
rjernst
rjernst reviewed Jul 22, 2025
View reviewed changes
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also check there is a qa test that actually uses shared data, so that we are sure the permission granted to server is sufficient?
@mosche
Copy link
Contributor Author

mosche commented Jul 22, 2025

There's lots of internalClusterTests using it, that's how i noticed this is missing. No QA rest tests though.
I tried testing locally, but couldn't figure out how this get's used and there's not much docs around it.
Happy to write a QA test if you could provide some pointers.
@rjernst
Copy link
Member

rjernst commented Jul 22, 2025

A rest test (java or yaml, doesn't matter) would be good as that is more realistic than an internalClusterTest. But if there are some tests already it doesn't need to block this PR, adding additional testing could be a followup.
@mosche mosche merged commit d16eb70 into elastic:main Jul 23, 2025
34 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 9.0 Commit could not be cherrypicked due to conflicts
❌ 9.1 Commit could not be cherrypicked due to conflicts
❌ 8.19 Commit could not be cherrypicked due to conflicts
❌ 8.18 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 131680
@mosche mosche added v9.2.0 and removed v9.0.2 labels Jul 23, 2025
@mosche mosche mentioned this pull request Jul 23, 2025
Merged
mosche added a commit to mosche/elasticsearch that referenced this pull request Jul 24, 2025
@mosche
Grant server read/write permissions on shared data path "path.shared_…
c2fc039 
…data". (elastic#131680) Relates to ES-12447 (cherry picked from commit d16eb70)
This was referenced Jul 24, 2025
Merged
Merged
Merged
mosche added a commit to mosche/elasticsearch that referenced this pull request Jul 24, 2025
@mosche
Grant server read/write permissions on shared data path "path.shared_…
a82c9b3 
…data". (elastic#131680) Relates to ES-12447 (cherry picked from commit d16eb70) # Conflicts: #	libs/entitlement/src/main/java/org/elasticsearch/entitlement/bootstrap/EntitlementBootstrap.java #	server/src/main/java/org/elasticsearch/bootstrap/Elasticsearch.java #	test/framework/src/main/java/org/elasticsearch/entitlement/bootstrap/TestEntitlementBootstrap.java
mosche added a commit to mosche/elasticsearch that referenced this pull request Jul 24, 2025
@mosche
Grant server read/write permissions on shared data path "path.shared_…
89c84da 
…data". (elastic#131680) Relates to ES-12447 (cherry picked from commit d16eb70)
mosche added a commit to mosche/elasticsearch that referenced this pull request Jul 24, 2025
@mosche
Grant server read/write permissions on shared data path "path.shared_…
61547bc 
…data". (elastic#131680) Relates to ES-12447 (cherry picked from commit d16eb70) # Conflicts: #	libs/entitlement/src/main/java/org/elasticsearch/entitlement/bootstrap/EntitlementBootstrap.java #	libs/entitlement/src/test/java/org/elasticsearch/entitlement/runtime/policy/PolicyManagerTests.java #	server/src/main/java/org/elasticsearch/bootstrap/Elasticsearch.java #	test/framework/src/main/java/org/elasticsearch/entitlement/bootstrap/TestEntitlementBootstrap.java
@mosche mosche mentioned this pull request Jul 24, 2025
Merged
@mosche
Copy link
Contributor Author

mosche commented Jul 24, 2025

💚 All backports created successfully

Status Branch Result
✅ 9.1
✅ 9.0
✅ 8.19
✅ 8.18

Questions ?

Please refer to the Backport tool documentation
elasticsearchmachine pushed a commit that referenced this pull request Jul 24, 2025
@mosche
Grant server read/write permissions on shared data path "path.shared_…
60b7470 
…data". (#131680) (#131849) Relates to ES-12447 (cherry picked from commit d16eb70) # Conflicts: #	libs/entitlement/src/main/java/org/elasticsearch/entitlement/bootstrap/EntitlementBootstrap.java #	server/src/main/java/org/elasticsearch/bootstrap/Elasticsearch.java #	test/framework/src/main/java/org/elasticsearch/entitlement/bootstrap/TestEntitlementBootstrap.java
elasticsearchmachine pushed a commit that referenced this pull request Jul 25, 2025
@mosche
Grant server read/write permissions on shared data path "path.shared_…
a80b094 
…data". (#131680) (#131847) Relates to ES-12447 (cherry picked from commit d16eb70)
elasticsearchmachine pushed a commit that referenced this pull request Jul 28, 2025
@mosche
Grant server read/write permissions on shared data path "path.shared_…
b8ccad7 
…data". (#131680) (#131850) Relates to ES-12447 (cherry picked from commit d16eb70)
elasticsearchmachine pushed a commit that referenced this pull request Jul 28, 2025
@mosche
Grant server read/write permissions on shared data path "path.shared_…
9a798cc 
…data". (#131680) (#131851) Relates to ES-12447 (cherry picked from commit d16eb70) # Conflicts: #	libs/entitlement/src/main/java/org/elasticsearch/entitlement/bootstrap/EntitlementBootstrap.java #	libs/entitlement/src/test/java/org/elasticsearch/entitlement/runtime/policy/PolicyManagerTests.java #	server/src/main/java/org/elasticsearch/bootstrap/Elasticsearch.java #	test/framework/src/main/java/org/elasticsearch/entitlement/bootstrap/TestEntitlementBootstrap.java
mosche added a commit that referenced this pull request Jul 29, 2025
@mosche
Fix file entitlements for shared data dir (#131748)
ab7bd9b 
This fixes incomplete entitlements added in #131680 and is necessary due to the lack of entitlement delegation.
mosche added a commit to mosche/elasticsearch that referenced this pull request Jul 29, 2025
@mosche
Fix file entitlements for shared data dir (elastic#131748)
d90d8f9 
This fixes incomplete entitlements added in elastic#131680 and is necessary due to the lack of entitlement delegation.
mosche added a commit to mosche/elasticsearch that referenced this pull request Jul 29, 2025
@mosche
Fix file entitlements for shared data dir (elastic#131748)
114282f 
This fixes incomplete entitlements added in elastic#131680 and is necessary due to the lack of entitlement delegation.
mosche added a commit to mosche/elasticsearch that referenced this pull request Jul 29, 2025
@mosche
Fix file entitlements for shared data dir (elastic#131748)
908113d 
This fixes incomplete entitlements added in elastic#131680 and is necessary due to the lack of entitlement delegation.
mosche added a commit to mosche/elasticsearch that referenced this pull request Jul 29, 2025
@mosche
Fix file entitlements for shared data dir (elastic#131748)
df65155 
This fixes incomplete entitlements added in elastic#131680 and is necessary due to the lack of entitlement delegation.
elasticsearchmachine pushed a commit that referenced this pull request Jul 29, 2025
@mosche
Fix file entitlements for shared data dir (#131748) (#132059)
c11f79d 
This fixes incomplete entitlements added in #131680 and is necessary due to the lack of entitlement delegation.
elasticsearchmachine pushed a commit that referenced this pull request Jul 29, 2025
@mosche
Fix file entitlements for shared data dir (#131748) (#132058)
9804bad 
This fixes incomplete entitlements added in #131680 and is necessary due to the lack of entitlement delegation.
elasticsearchmachine pushed a commit that referenced this pull request Jul 29, 2025
@mosche
Fix file entitlements for shared data dir (#131748) (#132061)
7f9d90f 
This fixes incomplete entitlements added in #131680 and is necessary due to the lack of entitlement delegation.
elasticsearchmachine pushed a commit that referenced this pull request Jul 29, 2025
@mosche
Fix file entitlements for shared data dir (#131748) (#132060)
31cad16 
This fixes incomplete entitlements added in #131680 and is necessary due to the lack of entitlement delegation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged backport pending >bug :Core/Infra/Entitlements Entitlements infrastructure Team:Core/Infra Meta label for core/infra team v8.18.5 v8.19.1 v9.0.5 v9.1.1 v9.2.0

3 participants

@mosche @elasticsearchmachine @rjernst