Fix bug in point in time response #131391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
benchaplin added >bug auto-backport 
| Pinging @elastic/es-search-foundations (Team:Search Foundations) |
| Hi @benchaplin, I've created a changelog YAML for you. |
cbuescher approved these changes Jul 17, 2025
| } | ||
| | ||
| String encodedId = Base64.getUrlEncoder().encodeToString(BytesReference.toBytes(pointInTimeId)); | ||
| BytesReference expected = new BytesArray(String.format(""" |
There was a problem hiding this comment.
Just to save you clicking through to the CI failures:
Forbidden method invocation: java.lang.String#format(java.lang.String,java.lang.Object[]) [Uses default locale]
in org.elasticsearch.action.search.OpenPointInTimeResponseTests (OpenPointInTimeResponseTests.java:43)
I always forget to add the locale as well.
This was referenced Jul 17, 2025
benchaplin added a commit to benchaplin/elasticsearch that referenced this pull request Jul 17, 2025
Correct response which had swapped "skipped" and "failed" shard counts.
benchaplin added a commit to benchaplin/elasticsearch that referenced this pull request Jul 17, 2025
Correct response which had swapped "skipped" and "failed" shard counts.
benchaplin added a commit to benchaplin/elasticsearch that referenced this pull request Jul 17, 2025
Correct response which had swapped "skipped" and "failed" shard counts.
benchaplin added a commit to benchaplin/elasticsearch that referenced this pull request Jul 17, 2025
Correct response which had swapped "skipped" and "failed" shard counts.
elasticsearchmachine pushed a commit that referenced this pull request Jul 17, 2025
elasticsearchmachine pushed a commit that referenced this pull request Jul 17, 2025
elasticsearchmachine pushed a commit that referenced this pull request Jul 17, 2025
elasticsearchmachine pushed a commit that referenced this pull request Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Resolves #131026.
The failed and skipped parameters are swapped.
See:
elasticsearch/server/src/main/java/org/elasticsearch/rest/action/RestActions.java
Lines 80 to 88 in 8bcb0c4