- Notifications
You must be signed in to change notification settings - Fork 25.5k
Unmute docker tests, add more logging and increase startup timeout #131203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- bump docker startup timeout to account for slow security autoconfiguration Resolves elastic#129808
while (started == false && timeElapsed < waitTime) { | ||
if (System.currentTimeMillis() - lastRequest > requestInterval) { | ||
if (caCert == null) { | ||
caCert = getCaCert(installation); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case of slow auto-configuration, the HTTP CA certificate may not have been configured when waitForElasticsearch
method is called. This would result in received plaintext http traffic on an https channel, closing connection Netty4HttpChannel
and test failure after 3 minutes. See this comment for more details: #123437 (comment)
failed = true; | ||
if (installation != null && installation.distribution.isDocker()) { | ||
logger.warn("Test {} failed. Printing logs for failed test...", description.getMethodName()); | ||
FileUtils.logAllLogs(installation.logs, logger); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the uncaught docker failures did not include any cluster logs, which makes it super hard to troubleshoot.
Pinging @elastic/es-security (Team:Security) |
💔 Backport failed
You can use sqren/backport to manually backport by running |
…lastic#131203) Unmuting 33 DockerTests with added additional logging on failures. Also, bumping docker startup timeout to account for slow security auto-configuration, and additionally moving CA certificates inside the retry while loop. Resolves elastic#129808 Resolves elastic#123437 Resolves elastic#120911 Resolves elastic#120914 Resolves elastic#120910 Resolves elastic#120918 Resolves elastic#120925 Resolves elastic#124990 Resolves elastic#116636 Resolves elastic#125680 Resolves elastic#116147 Resolves elastic#126232 Resolves elastic#126145 Resolves elastic#116866 Resolves elastic#126936 Resolves elastic#127081 Resolves elastic#127158 Resolves elastic#127138 Resolves elastic#128018 Resolves elastic#128031 Resolves elastic#128110 Resolves elastic#128006 Resolves elastic#128174 Resolves elastic#128144 Resolves elastic#128165 Resolves elastic#128075 Resolves elastic#128117 Resolves elastic#128121 Resolves elastic#128115 Resolves elastic#128230 Resolves elastic#128120 Resolves elastic#128996 Resolves elastic#128867 (cherry picked from commit 4806156) # Conflicts: # muted-tests.yml
…lastic#131203) Unmuting 33 DockerTests with added additional logging on failures. Also, bumping docker startup timeout to account for slow security auto-configuration, and additionally moving CA certificates inside the retry while loop. Resolves elastic#129808 Resolves elastic#123437 Resolves elastic#120911 Resolves elastic#120914 Resolves elastic#120910 Resolves elastic#120918 Resolves elastic#120925 Resolves elastic#124990 Resolves elastic#116636 Resolves elastic#125680 Resolves elastic#116147 Resolves elastic#126232 Resolves elastic#126145 Resolves elastic#116866 Resolves elastic#126936 Resolves elastic#127081 Resolves elastic#127158 Resolves elastic#127138 Resolves elastic#128018 Resolves elastic#128031 Resolves elastic#128110 Resolves elastic#128006 Resolves elastic#128174 Resolves elastic#128144 Resolves elastic#128165 Resolves elastic#128075 Resolves elastic#128117 Resolves elastic#128121 Resolves elastic#128115 Resolves elastic#128230 Resolves elastic#128120 Resolves elastic#128996 Resolves elastic#128867 (cherry picked from commit 4806156) # Conflicts: # muted-tests.yml
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
…lastic#131203) Unmuting 33 DockerTests with added additional logging on failures. Also, bumping docker startup timeout to account for slow security auto-configuration, and additionally moving CA certificates inside the retry while loop. Resolves elastic#129808 Resolves elastic#123437 Resolves elastic#120911 Resolves elastic#120914 Resolves elastic#120910 Resolves elastic#120918 Resolves elastic#120925 Resolves elastic#124990 Resolves elastic#116636 Resolves elastic#125680 Resolves elastic#116147 Resolves elastic#126232 Resolves elastic#126145 Resolves elastic#116866 Resolves elastic#126936 Resolves elastic#127081 Resolves elastic#127158 Resolves elastic#127138 Resolves elastic#128018 Resolves elastic#128031 Resolves elastic#128110 Resolves elastic#128006 Resolves elastic#128174 Resolves elastic#128144 Resolves elastic#128165 Resolves elastic#128075 Resolves elastic#128117 Resolves elastic#128121 Resolves elastic#128115 Resolves elastic#128230 Resolves elastic#128120 Resolves elastic#128996 Resolves elastic#128867 (cherry picked from commit 4806156) # Conflicts: # muted-tests.yml
…out (#131203) (#131293) * Unmute docker tests, add more logging and increase startup timeout (#131203) Unmuting 33 DockerTests with added additional logging on failures. Also, bumping docker startup timeout to account for slow security auto-configuration, and additionally moving CA certificates inside the retry while loop. Resolves #129808 Resolves #123437 Resolves #120911 Resolves #120914 Resolves #120910 Resolves #120918 Resolves #120925 Resolves #124990 Resolves #116636 Resolves #125680 Resolves #116147 Resolves #126232 Resolves #126145 Resolves #116866 Resolves #126936 Resolves #127081 Resolves #127158 Resolves #127138 Resolves #128018 Resolves #128031 Resolves #128110 Resolves #128006 Resolves #128174 Resolves #128144 Resolves #128165 Resolves #128075 Resolves #128117 Resolves #128121 Resolves #128115 Resolves #128230 Resolves #128120 Resolves #128996 Resolves #128867 (cherry picked from commit 4806156) # Conflicts: # muted-tests.yml * call dumpDebug
…eout (#131203) (#131294) * Unmute docker tests, add more logging and increase startup timeout (#131203) Unmuting 33 DockerTests with added additional logging on failures. Also, bumping docker startup timeout to account for slow security auto-configuration, and additionally moving CA certificates inside the retry while loop. Resolves #129808 Resolves #123437 Resolves #120911 Resolves #120914 Resolves #120910 Resolves #120918 Resolves #120925 Resolves #124990 Resolves #116636 Resolves #125680 Resolves #116147 Resolves #126232 Resolves #126145 Resolves #116866 Resolves #126936 Resolves #127081 Resolves #127158 Resolves #127138 Resolves #128018 Resolves #128031 Resolves #128110 Resolves #128006 Resolves #128174 Resolves #128144 Resolves #128165 Resolves #128075 Resolves #128117 Resolves #128121 Resolves #128115 Resolves #128230 Resolves #128120 Resolves #128996 Resolves #128867 (cherry picked from commit 4806156) # Conflicts: # muted-tests.yml * call dumpDebug
…eout (#131203) (#131295) * Unmute docker tests, add more logging and increase startup timeout (#131203) Unmuting 33 DockerTests with added additional logging on failures. Also, bumping docker startup timeout to account for slow security auto-configuration, and additionally moving CA certificates inside the retry while loop. Resolves #129808 Resolves #123437 Resolves #120911 Resolves #120914 Resolves #120910 Resolves #120918 Resolves #120925 Resolves #124990 Resolves #116636 Resolves #125680 Resolves #116147 Resolves #126232 Resolves #126145 Resolves #116866 Resolves #126936 Resolves #127081 Resolves #127158 Resolves #127138 Resolves #128018 Resolves #128031 Resolves #128110 Resolves #128006 Resolves #128174 Resolves #128144 Resolves #128165 Resolves #128075 Resolves #128117 Resolves #128121 Resolves #128115 Resolves #128230 Resolves #128120 Resolves #128996 Resolves #128867 (cherry picked from commit 4806156) # Conflicts: # muted-tests.yml * call dumpDebug
This test timed out due to slow security auto-configuration. The elastic#131203 increased timeout from 30s to 45s, which should hopefully be enough. Resolves elastic#131107
…out (#131203) (#131292) * Unmute docker tests, add more logging and increase startup timeout (#131203) Unmuting 33 DockerTests with added additional logging on failures. Also, bumping docker startup timeout to account for slow security auto-configuration, and additionally moving CA certificates inside the retry while loop. Resolves #129808 Resolves #123437 Resolves #120911 Resolves #120914 Resolves #120910 Resolves #120918 Resolves #120925 Resolves #124990 Resolves #116636 Resolves #125680 Resolves #116147 Resolves #126232 Resolves #126145 Resolves #116866 Resolves #126936 Resolves #127081 Resolves #127158 Resolves #127138 Resolves #128018 Resolves #128031 Resolves #128110 Resolves #128006 Resolves #128174 Resolves #128144 Resolves #128165 Resolves #128075 Resolves #128117 Resolves #128121 Resolves #128115 Resolves #128230 Resolves #128120 Resolves #128996 Resolves #128867 (cherry picked from commit 4806156) # Conflicts: # muted-tests.yml * call dump debug logs
@slobodanadamovic Our periodic packaging jobs have tons of failures now after unmuting all of these tests... See here for an example: https://buildkite.com/elastic/elasticsearch-periodic-packaging/builds/9057 |
Unmuting 33 DockerTests with added additional logging on failures.
Also, bumping docker startup timeout to account for slow security
auto-configuration, and additionally moving CA certificates inside
the retry while loop.
Resolves #129808
Resolves #123437
Resolves #120911
Resolves #120914
Resolves #120910
Resolves #120918
Resolves #120925
Resolves #124990
Resolves #116636
Resolves #125680
Resolves #116147
Resolves #126232
Resolves #126145
Resolves #116866
Resolves #126936
Resolves #127081
Resolves #127158
Resolves #127138
Resolves #128018
Resolves #128031
Resolves #128110
Resolves #128006
Resolves #128174
Resolves #128144
Resolves #128165
Resolves #128075
Resolves #128117
Resolves #128121
Resolves #128115
Resolves #128230
Resolves #128120
Resolves #128996
Resolves #128867