Add attribute count to SamlAttribute toString #131173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sometimes SAML IdPs send what _should_ be a list of values as a single comma-separated string. That is, we expect something using SAML's multi-valued attribute feature: <saml:Attribute NameFormat="urn:oasis:names:tc:SAML:2.0:attrname-format:uri" Name="http://idp.example.org/attributes/groups" FriendlyName="groups"> <saml:AttributeValue>engineering</saml:AttributeValue> <saml:AttributeValue>elasticsearch-admins</saml:AttributeValue> <saml:AttributeValue>employees</saml:AttributeValue> </saml:Attribute> but we get <saml:Attribute NameFormat="urn:oasis:names:tc:SAML:2.0:attrname-format:uri" Name="http://idp.example.org/attributes/groups" FriendlyName="groups"> <saml:AttributeValue>engineering,elasticsearch-admins,employees</saml:AttributeValue> </saml:Attribute> In order to help detect these cases, this commit changes the `toString()` on `SamlAttribute` to include the length (e.g. `(len=1)`) at the end Relates: elastic#84379, elastic#102769
tvernum added >enhancement :Security/Authentication 
Collaborator
| Pinging @elastic/es-security (Team:Security) |
Collaborator
| Hi @tvernum, I've created a changelog YAML for you. |
Contributor Author
| Ping @ankit--sethi |
ankit--sethi approved these changes Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Sometimes SAML IdPs send what should be a list of values as a single comma-separated string.
That is, we expect something using SAML's multi-valued attribute feature:
but we get
In order to help detect these cases, this commit changes the
toString()onSamlAttributeto include the length (e.g.(len=1)) at the endRelates: #84379, #102769