- Notifications
You must be signed in to change notification settings - Fork 25.7k
Add existing shards allocator settings to failure store allowed list. #131056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jbaiera merged 7 commits into elastic:main from jbaiera:fix-failure-store-removing-allocator-settings Jul 11, 2025
Merged
Add existing shards allocator settings to failure store allowed list. #131056
jbaiera merged 7 commits into elastic:main from jbaiera:fix-failure-store-removing-allocator-settings Jul 11, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
| Pinging @elastic/es-data-management (Team:Data Management) |
Collaborator
| Hi @jbaiera, I've created a changelog YAML for you. |
dakrone approved these changes Jul 10, 2025
Member
dakrone left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I left one comment
server/src/main/java/org/elasticsearch/cluster/metadata/DataStreamFailureStoreDefinition.java Show resolved Hide resolved
jbaiera added a commit to jbaiera/elasticsearch that referenced this pull request Jul 11, 2025
…elastic#131056) * Add existing shards allocator settings to failure store allowed list. * Cleanup docstring * Update docs/changelog/131056.yaml * Add comment
Collaborator
jbaiera added a commit to jbaiera/elasticsearch that referenced this pull request Jul 11, 2025
…elastic#131056) * Add existing shards allocator settings to failure store allowed list. * Cleanup docstring * Update docs/changelog/131056.yaml * Add comment
szybia added a commit to szybia/elasticsearch that referenced this pull request Jul 14, 2025
…king * upstream/main: (33 commits) Allow both WithEntitlementsOnTestCode and EntitledTestPackages together (elastic#130826) Move streams status actions to cluster:monitor group (elastic#131015) Update JDK base image for OIDC fixture (elastic#131176) Mute org.elasticsearch.xpack.esql.ccq.MultiClustersIT testLookupJoinAliases elastic#131166 Mute org.elasticsearch.index.engine.ThreadPoolMergeExecutorServiceDiskSpaceTests testEnqueuedMergeTasksAreUnblockedWhenEstimatedMergeSizeChanges elastic#131165 Mute org.elasticsearch.xpack.esql.ccq.MultiClustersIT testNotLikeListKeyword elastic#131155 Mute org.elasticsearch.xpack.esql.qa.multi_node.GenerativeIT test elastic#131154 Check file entitlements on the Lucene FilterFileSystem in tests (elastic#130825) Mute org.elasticsearch.xpack.esql.qa.multi_node.EsqlSpecIT test {lookup-join.MvJoinKeyOnFromAfterStats ASYNC} elastic#131148 Move FrequencyCappedAction to common package (elastic#131060) Mute org.elasticsearch.xpack.esql.action.CrossClusterAsyncQueryStopIT testStopQueryLocal elastic#121672 Remove nesting from multi allocation decision (elastic#130844) Disable async search rest tests in release builds (elastic#131132) Fix testStopQueryLocal (elastic#131130) Fixes based on resharding disruption tests (elastic#130870) Remove inactive logger (elastic#131121) Add wait for remote start for the test (elastic#131124) Add existing shards allocator settings to failure store allowed list. (elastic#131056) Don't allow field caps to use semantic queries as index filters (elastic#131111) issue should be already fixed by elastic#121466 (elastic#130860) ...
mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Jul 17, 2025
…elastic#131056) * Add existing shards allocator settings to failure store allowed list. * Cleanup docstring * Update docs/changelog/131056.yaml * Add comment
mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Jul 17, 2025
…elastic#131056) * Add existing shards allocator settings to failure store allowed list. * Cleanup docstring * Update docs/changelog/131056.yaml * Add comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged >bug :Data Management/Data streams Data streams and their lifecycles Team:Data Management Meta label for data/management team v9.2.0
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Adds the existing shards allocator settings to the failure store settings allowed list. This setting is needed for recovery operations in different deployments and should not be filtered out.