Skip to content

Conversation

DaveCTurner
Copy link
Contributor

This picks up the fix for the locale bug reported at
aws/aws-sdk-java-v2#5968.

This reverts the patching of the library added in commit
2697a3a, except for the test
enhancement.

Fix confirmed in e.g. locale ar-ER with

./gradlew ":plugins:discovery-ec2:test" \ --tests "org.elasticsearch.discovery.ec2.Ec2DiscoveryTests.testFilterByTags" \ -Dtests.seed=596874EED28A2B92 -Dtests.locale=ar-ER -Dtests.timezone=NET \ -Druntime.java=24 
This picks up the fix for the locale bug reported at aws/aws-sdk-java-v2#5968. This reverts the patching of the library added in commit 2697a3a, except for the test enhancement. Fix confirmed in e.g. locale `ar-ER` with ./gradlew ":plugins:discovery-ec2:test" \ --tests "org.elasticsearch.discovery.ec2.Ec2DiscoveryTests.testFilterByTags" \ -Dtests.seed=596874EED28A2B92 -Dtests.locale=ar-ER -Dtests.timezone=NET \ -Druntime.java=24
@DaveCTurner DaveCTurner requested a review from a team as a code owner July 10, 2025 19:48
@DaveCTurner DaveCTurner added :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >upgrade :Distributed Coordination/Discovery-Plugins Anything related to our integration plugins with EC2, GCP and Azure auto-backport Automatically create backport pull requests when merged v9.2.0 v9.1.1 v8.19.1 labels Jul 10, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Coordination Meta label for Distributed Coordination team label Jul 10, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

@elasticsearchmachine
Copy link
Collaborator

Hi @DaveCTurner, I've created a changelog YAML for you.

@DaveCTurner DaveCTurner removed the :Distributed Coordination/Discovery-Plugins Anything related to our integration plugins with EC2, GCP and Azure label Jul 10, 2025
@DaveCTurner DaveCTurner added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jul 11, 2025
@elasticsearchmachine elasticsearchmachine merged commit ebdfa9c into elastic:main Jul 16, 2025
33 checks passed
@DaveCTurner DaveCTurner deleted the 2025/07/10/fix-aws-v2-sdk-locale-bug branch July 16, 2025 09:48
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Jul 16, 2025
This picks up the fix for the locale bug reported at aws/aws-sdk-java-v2#5968. This reverts the patching of the library added in commit 2697a3a, except for the test enhancement. Fix confirmed in e.g. locale `ar-ER` with ./gradlew ":plugins:discovery-ec2:test" \ --tests "org.elasticsearch.discovery.ec2.Ec2DiscoveryTests.testFilterByTags" \ -Dtests.seed=596874EED28A2B92 -Dtests.locale=ar-ER -Dtests.timezone=NET \ -Druntime.java=24
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Jul 16, 2025
This picks up the fix for the locale bug reported at aws/aws-sdk-java-v2#5968. This reverts the patching of the library added in commit 2697a3a, except for the test enhancement. Fix confirmed in e.g. locale `ar-ER` with ./gradlew ":plugins:discovery-ec2:test" \ --tests "org.elasticsearch.discovery.ec2.Ec2DiscoveryTests.testFilterByTags" \ -Dtests.seed=596874EED28A2B92 -Dtests.locale=ar-ER -Dtests.timezone=NET \ -Druntime.java=24
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
9.1
8.19
elasticsearchmachine pushed a commit that referenced this pull request Jul 16, 2025
This picks up the fix for the locale bug reported at aws/aws-sdk-java-v2#5968. This reverts the patching of the library added in commit 2697a3a, except for the test enhancement. Fix confirmed in e.g. locale `ar-ER` with ./gradlew ":plugins:discovery-ec2:test" \ --tests "org.elasticsearch.discovery.ec2.Ec2DiscoveryTests.testFilterByTags" \ -Dtests.seed=596874EED28A2B92 -Dtests.locale=ar-ER -Dtests.timezone=NET \ -Druntime.java=24
elasticsearchmachine pushed a commit that referenced this pull request Jul 16, 2025
This picks up the fix for the locale bug reported at aws/aws-sdk-java-v2#5968. This reverts the patching of the library added in commit 2697a3a, except for the test enhancement. Fix confirmed in e.g. locale `ar-ER` with ./gradlew ":plugins:discovery-ec2:test" \ --tests "org.elasticsearch.discovery.ec2.Ec2DiscoveryTests.testFilterByTags" \ -Dtests.seed=596874EED28A2B92 -Dtests.locale=ar-ER -Dtests.timezone=NET \ -Druntime.java=24
szybia added a commit to szybia/elasticsearch that referenced this pull request Jul 16, 2025
…king * upstream/main: (91 commits) Mute org.elasticsearch.packaging.test.DockerTests test130JavaHasCorrectOwnership elastic#131369 Add exception logging when interrupted (elastic#131153) Mute org.elasticsearch.packaging.test.DockerTests test140CgroupOsStatsAreAvailable elastic#131372 Mute org.elasticsearch.packaging.test.DockerTests test070BindMountCustomPathConfAndJvmOptions elastic#131366 Mute org.elasticsearch.xpack.test.rest.XPackRestIT test {p0=ml/delete_expired_data/Test delete expired data with body parameters} elastic#131364 Mute org.elasticsearch.xpack.esql.vector.VectorSimilarityFunctionsIT testSimilarityBetweenConstantVectorAndField {functionName=v_cosine similarityFunction=COSINE} elastic#131363 Mute org.elasticsearch.xpack.esql.vector.VectorSimilarityFunctionsIT testDifferentDimensions {functionName=v_cosine similarityFunction=COSINE} elastic#131362 Mute org.elasticsearch.xpack.esql.vector.VectorSimilarityFunctionsIT testSimilarityBetweenConstantVectors {functionName=v_cosine similarityFunction=COSINE} elastic#131361 Check SCORE_FUNCTION capability in VerifierTests (elastic#131352) Replace deprecated routingTable table call in tests (elastic#131005) [DOCS] Remove misused applies_to tag (elastic#131349) Adj ivf postings list building (elastic#130843) [Transform] Read metadata from Project State (elastic#131205) Add note on o11y to architecture guide (elastic#131291) Upgrade AWS Java SDK to 2.31.78 (elastic#131050) Support Fields API in conditional ingest processors (elastic#121914) ESQL - KNN function uses prefilters when pushed down to Lucene (elastic#131004) Add docs for ES|QL query logs (elastic#131287) Simplify `expectedFinalRegisterValue` computation (elastic#131274) Mute org.elasticsearch.test.rest.yaml.RcsCcsCommonYamlTestSuiteIT test {p0=search/110_field_collapsing/field collapsing, inner_hits and maxConcurrentGroupRequests} elastic#131348 ...
ywangd added a commit to ywangd/elasticsearch that referenced this pull request Jul 17, 2025
Also add test to ensure the file has at least one entry for each region so that it is easy to spot missing regions in future upgrades. Relates: elastic#131050
elasticsearchmachine pushed a commit that referenced this pull request Jul 17, 2025
Also add test to ensure the file has at least one entry for each region so that it is easy to spot missing regions in future upgrades. Relates: #131050 Resolves: #131392
ywangd added a commit to ywangd/elasticsearch that referenced this pull request Jul 17, 2025
Also add test to ensure the file has at least one entry for each region so that it is easy to spot missing regions in future upgrades. Relates: elastic#131050 Resolves: elastic#131392
elasticsearchmachine pushed a commit that referenced this pull request Jul 17, 2025
Also add test to ensure the file has at least one entry for each region so that it is easy to spot missing regions in future upgrades. Relates: #131050 Resolves: #131392
elasticsearchmachine pushed a commit that referenced this pull request Jul 18, 2025
Also add test to ensure the file has at least one entry for each region so that it is easy to spot missing regions in future upgrades. Relates: #131050 Resolves: #131392 Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed Coordination Meta label for Distributed Coordination team >upgrade v8.19.1 v9.1.1 v9.2.0

3 participants