Fix msearch request parsing when index expression is null #130776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
smalyshev changed the title smalyshev added :Search Foundations/Search 
| Hi @smalyshev, I've created a changelog YAML for you. |
elasticsearchmachine added Team:Core/Infra | Pinging @elastic/es-core-infra (Team:Core/Infra) |
| Pinging @elastic/es-search-foundations (Team:Search Foundations) |
drempapis reviewed Jul 8, 2025
server/src/test/java/org/elasticsearch/action/search/MultiSearchRequestTests.java Outdated Show resolved Hide resolved
javanna approved these changes Jul 8, 2025
There was a problem hiding this comment.
Thanks a lot for picking this up! The test needs a small adjustment I believe. No need for another review round once that is addressed.
I am curious to see if this has side effects on other consumers of the method. On the other hand null values cause NPE before so this fix can't hurt.
server/src/test/java/org/elasticsearch/action/search/MultiSearchRequestTests.java Outdated Show resolved Hide resolved
server/src/test/java/org/elasticsearch/action/search/MultiSearchRequestTests.java Outdated Show resolved Hide resolved
drempapis approved these changes Jul 9, 2025
smalyshev added a commit to smalyshev/elasticsearch that referenced this pull request Jul 10, 2025
…0776) * Fix parsing when index expression is null
This was referenced Jul 10, 2025
smalyshev added a commit to smalyshev/elasticsearch that referenced this pull request Jul 10, 2025
…0776) * Fix parsing when index expression is null
This was referenced Jul 10, 2025
smalyshev added a commit to smalyshev/elasticsearch that referenced this pull request Jul 10, 2025
…0776) * Fix parsing when index expression is null
smalyshev added a commit to smalyshev/elasticsearch that referenced this pull request Jul 10, 2025
…0776) * Fix parsing when index expression is null
smalyshev added a commit to smalyshev/elasticsearch that referenced this pull request Jul 10, 2025
…0776) * Fix parsing when index expression is null
elasticsearchmachine pushed a commit that referenced this pull request Jul 10, 2025
elasticsearchmachine pushed a commit that referenced this pull request Jul 10, 2025
elasticsearchmachine pushed a commit that referenced this pull request Jul 10, 2025
elasticsearchmachine pushed a commit that referenced this pull request Jul 10, 2025
elasticsearchmachine pushed a commit that referenced this pull request Jul 10, 2025
mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Jul 17, 2025
…0776) * Fix parsing when index expression is null
mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Jul 17, 2025
…0776) * Fix parsing when index expression is null
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Method
XContentMapValues.nodeStringArrayValuedoes not check for null before trying to manipulate the value, butnullis a legit value that can come from JSON, we should check for it.Fixes #129631