Simplified Linear & RRF Retrievers - Return error on empty fields param #129962
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Updates the simplified
linear
&rrf
retrievers to return an error when thefields
param is empty:Previously, this would query all fields specified by
index.query.default_field
, but this creates a potential future problem with supporting combinations ofquery
andretrievers
, like this:In contrast, this should (at most) only execute the custom sub-retrievers and not query any fields for "Harry Potter". Returning an error for now when the
fields
param is empty gives us more options for how to combinequery
andretrievers
in the future.