- Notifications
You must be signed in to change notification settings - Fork 25.5k
Deprecate indices.merge.scheduler.use_thread_pool setting #129464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
elasticsearchmachine merged 13 commits into elastic:main from albertzaharovits:deprecate-setting-to-switch-to-the-old-concurrent-merge-scheduler Jun 18, 2025
Merged
Deprecate indices.merge.scheduler.use_thread_pool setting #129464
elasticsearchmachine merged 13 commits into elastic:main from albertzaharovits:deprecate-setting-to-switch-to-the-old-concurrent-merge-scheduler Jun 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
Hi @albertzaharovits, I've created a changelog YAML for you. Note that since this PR is labelled |
henningandersen approved these changes Jun 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (provided CI passes)
…rrent-merge-scheduler
…rrent-merge-scheduler
…rrent-merge-scheduler
…rrent-merge-scheduler
…rrent-merge-scheduler
albertzaharovits added a commit to albertzaharovits/elasticsearch that referenced this pull request Jun 18, 2025
…9464) This deprecates the `indices.merge.scheduler.use_thread_pool` setting that was introduced in elastic#120869 because this setting should not normally be used, unless instructed so by engineering to get around temporary issues with the new threadpool-based merge scheduler.
elasticsearchmachine pushed a commit that referenced this pull request Jun 18, 2025
…9464) (#129628) * Deprecate indices.merge.scheduler.use_thread_pool setting (#129464) This deprecates the `indices.merge.scheduler.use_thread_pool` setting that was introduced in #120869 because this setting should not normally be used, unless instructed so by engineering to get around temporary issues with the new threadpool-based merge scheduler. * Update warning msg
kderusso pushed a commit to kderusso/elasticsearch that referenced this pull request Jun 23, 2025
…9464) This deprecates the `indices.merge.scheduler.use_thread_pool` setting that was introduced in elastic#120869 because this setting should not normally be used, unless instructed so by engineering to get around temporary issues with the new threadpool-based merge scheduler.
mridula-s109 pushed a commit to mridula-s109/elasticsearch that referenced this pull request Jun 25, 2025
…9464) This deprecates the `indices.merge.scheduler.use_thread_pool` setting that was introduced in elastic#120869 because this setting should not normally be used, unless instructed so by engineering to get around temporary issues with the new threadpool-based merge scheduler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >deprecation :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. serverless-linked Added by automation, don't add manually Team:Distributed Indexing Meta label for Distributed Indexing team v8.19.0 v9.0.3 v9.1.0
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This deprecates the
indices.merge.scheduler.use_thread_pool
setting that was introduced in #120869 because this setting should not normally be used, unless instructed so by engineering to get around temporary issues with the new threadpool-based merge scheduler.