Better handling of node ids from shutdown metadata #128298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ldematte added >bug :Core/Infra/Node Lifecycle 
| Pinging @elastic/es-core-infra (Team:Core/Infra) |
| Hi @ldematte, I've created a changelog YAML for you. |
…asticsearch into fix-diskthresholdmonitor-npe
mosche approved these changes May 23, 2025
...er/src/test/java/org/elasticsearch/cluster/routing/allocation/DiskThresholdMonitorTests.java Outdated Show resolved Hide resolved
...er/src/test/java/org/elasticsearch/cluster/routing/allocation/DiskThresholdMonitorTests.java Outdated Show resolved Hide resolved
ldematte added a commit to ldematte/elasticsearch that referenced this pull request May 23, 2025
Currently, the DiskThresholdMonitor code considers shutdown metadata to identify nodes that are being replaced. If the node-to-be-replaced (source) leaves the cluster before the corresponding shutdown metadata is removed from the cluster state, we can have a NPE. This PR adds a test for that and improves a bit code to handle node ids for source and target from shutdown metadata. Fixes elastic#100201
💚 Backport successful
|
elasticsearchmachine pushed a commit that referenced this pull request May 23, 2025
…128364) * Better handling of node ids from shutdown metadata (#128298) Currently, the DiskThresholdMonitor code considers shutdown metadata to identify nodes that are being replaced. If the node-to-be-replaced (source) leaves the cluster before the corresponding shutdown metadata is removed from the cluster state, we can have a NPE. This PR adds a test for that and improves a bit code to handle node ids for source and target from shutdown metadata. Fixes #100201 * remove project stuff from backport
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Currently, the DiskThresholdMonitor code considers shutdown metadata to identify nodes that are being replaced. If the node-to-be-replaced (source) leaves the cluster before the corresponding shutdown metadata is removed from the cluster state, we can have a NPE. This PR adds a test for that and improves a bit code to handle node ids for source and target from shutdown metadata.
Fixes #100201