[ML] Fixing Google Vertex AI Rerank task type location field #127856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jonathan-buttner added >bug :ml 
| Pinging @elastic/ml-core (Team:ML) |
| Hi @jonathan-buttner, I've created a changelog YAML for you. |
dan-rubinstein approved these changes May 7, 2025
jonathan-buttner added a commit to jonathan-buttner/elasticsearch that referenced this pull request May 7, 2025
…#127856) * Fixing rerank location * Update docs/changelog/127856.yaml * Refactor changelog
This was referenced May 7, 2025
jonathan-buttner added a commit to jonathan-buttner/elasticsearch that referenced this pull request May 7, 2025
…#127856) * Fixing rerank location * Update docs/changelog/127856.yaml * Refactor changelog
jonathan-buttner added a commit to jonathan-buttner/elasticsearch that referenced this pull request May 7, 2025
…#127856) * Fixing rerank location * Update docs/changelog/127856.yaml * Refactor changelog
elasticsearchmachine pushed a commit that referenced this pull request May 7, 2025
#127867) * Fixing rerank location * Update docs/changelog/127856.yaml * Refactor changelog
elasticsearchmachine pushed a commit that referenced this pull request May 7, 2025
#127865) * Fixing rerank location * Update docs/changelog/127856.yaml * Refactor changelog
elasticsearchmachine pushed a commit that referenced this pull request May 7, 2025
#127866) * Fixing rerank location * Update docs/changelog/127856.yaml * Refactor changelog
ywangd pushed a commit to ywangd/elasticsearch that referenced this pull request May 9, 2025
…#127856) * Fixing rerank location * Update docs/changelog/127856.yaml * Refactor changelog
jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request May 12, 2025
…#127856) * Fixing rerank location * Update docs/changelog/127856.yaml * Refactor changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the
locationfield is not needed for the rerank task type. The services API was reporting that it was required.