Fix npe when using source confirmed text query against missing field #127414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
benwtrent added >bug auto-backport 
elasticsearchmachine added the Team:Search Relevance 
Collaborator
| Pinging @elastic/es-search-relevance (Team:Search Relevance) |
Collaborator
| Hi @benwtrent, I've created a changelog YAML for you. |
benwtrent added the auto-merge-without-approval 
pmpailis approved these changes Apr 28, 2025
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
Member Author
| It doesn't need to be backported to v8.18/19 as those didn't suffer from this bug as it was introduced with the |
Member Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Apr 29, 2025
…lastic#127414) We should check for the field and statistics actually existing when checking matches and explanation with `match_only_text` fields closes: elastic#125635 (cherry picked from commit 3d67e0e)
elasticsearchmachine pushed a commit that referenced this pull request Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We should check for the field and statistics actually existing when checking matches and explanation with
match_only_textfieldscloses: #125635