Skip to content

Allow partial results by default in ES|QL - Take 2 #127351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 28, 2025
Merged

Allow partial results by default in ES|QL - Take 2 #127351

merged 10 commits into from
Apr 28, 2025

Conversation

smalyshev
Copy link
Contributor

This reverts commit 8f38b13.

Restore changes from #125060 now that the breakage should be fixed.

See #125060 for original patch.
@smalyshev
Revert "ESQL: Revert "Allow partial results by default in ES|QL (elas…
fcf476c 
…tic#125060)" (elastic#126286)" This reverts commit 8f38b13. Restore changes from elastic#125060 now that the breakage should be fixed.
@smalyshev smalyshev requested a review from dnhatn April 24, 2025 20:44
@smalyshev smalyshev added :Analytics/ES|QL AKA ESQL v8.19.0 auto-backport Automatically create backport pull requests when merged labels Apr 24, 2025
@smalyshev smalyshev force-pushed the enable-partial-results-take-2 branch from d2e132d to 7ae2631 Compare April 24, 2025 21:51
dnhatn
dnhatn approved these changes Apr 25, 2025
View reviewed changes
Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Stas!
@smalyshev smalyshev marked this pull request as ready for review April 25, 2025 07:09
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Apr 25, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)
@elasticsearchmachine
Copy link
Collaborator

Hi @smalyshev, I've created a changelog YAML for you.
@smalyshev
Copy link
Contributor Author

I'll wait with merging it till Monday to avoid disruption if anything goes wrong again.
@smalyshev smalyshev requested a review from quux00 April 25, 2025 07:12
@idegtiarenko
Copy link
Contributor

Do you mind adding a test that checks behavior when we query non-existing index? Or is there one already?
@smalyshev
Copy link
Contributor Author

@idegtiarenko There are several that have been added in #126738 and previous fixes.
@smalyshev smalyshev merged commit eb479e5 into elastic:main Apr 28, 2025
17 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 8.19 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 127351
@elasticsearchmachine
Copy link
Collaborator

@smalyshev according to this PR's labels, I need to update the changelog YAML, but I can't because the PR is closed. Please either update the changelog yourself on the appropriate branch, or adjust the labels. Specifically:

  • The PR is not labelled >breaking but the changelog has a breaking section
  • The PR is not labelled >breaking-java but the changelog has a breaking section
smalyshev added a commit to smalyshev/elasticsearch that referenced this pull request Apr 28, 2025
@smalyshev
Allow partial results by default in ES|QL - Take 2 (elastic#127351)
da2cc30 
* Revert "ESQL: Revert "Allow partial results by default in ES|QL (elastic#125060)" (elastic#126286)" This reverts commit 8f38b13. Restore changes from elastic#125060 now that the breakage should be fixed. (cherry picked from commit eb479e5) # Conflicts: #	docs/release-notes/breaking-changes.md #	x-pack/plugin/build.gradle #	x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plugin/ClusterComputeHandler.java
@smalyshev smalyshev mentioned this pull request Apr 28, 2025
Merged
@smalyshev
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.19

Questions ?

Please refer to the Backport tool documentation
@elasticsearchmachine
Copy link
Collaborator

@smalyshev according to this PR's labels, I need to update the changelog YAML, but I can't because the PR is closed. Please either update the changelog yourself on the appropriate branch, or adjust the labels. Specifically:

  • The PR is not labelled >breaking-java but the changelog has a breaking section
elasticsearchmachine pushed a commit that referenced this pull request Apr 28, 2025
@smalyshev
[8.19] Allow partial results by default in ES|QL - Take 2 (#127351) (#…
17c3f33 
…127474) * Allow partial results by default in ES|QL - Take 2 (#127351) * Revert "ESQL: Revert "Allow partial results by default in ES|QL (#125060)" (#126286)" This reverts commit 8f38b13. Restore changes from #125060 now that the breakage should be fixed. (cherry picked from commit eb479e5) # Conflicts: #	docs/release-notes/breaking-changes.md #	x-pack/plugin/build.gradle #	x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plugin/ClusterComputeHandler.java * skip test * fix test * fix test
@elasticsearchmachine
Copy link
Collaborator

@smalyshev according to this PR's labels, I need to update the changelog YAML, but I can't because the PR is closed. Please either update the changelog yourself on the appropriate branch, or adjust the labels. Specifically:

  • The PR is not labelled >breaking-java but the changelog has a breaking section
@smalyshev smalyshev deleted the enable-partial-results-take-2 branch April 29, 2025 19:20
@smalyshev smalyshev mentioned this pull request Apr 29, 2025
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged >breaking >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.19.0 v9.1.0

4 participants

@smalyshev @elasticsearchmachine @idegtiarenko @dnhatn