Allow float settings to be configured with other settings as default #126751
+43 −2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nicktindall added >enhancement :Core/Infra/Settings 
elasticsearchmachine added v9.1.0 Team:Core/Infra 
| Pinging @elastic/es-core-infra (Team:Core/Infra) |
| Hi @nicktindall, I've created a changelog YAML for you. |
ldematte approved these changes Apr 14, 2025
| ); | ||
| assertThat( | ||
| floatSetting.get( | ||
| Settings.builder().put("float_val.default", configuredDefaultValue).put("float_val", configuredSettingValue).build() |
There was a problem hiding this comment.
Nit: this would have been maybe more useful if it was something else, e.g.
assertThat( floatSetting.get( Settings.builder().put("float_val.default", someOtherDefaultValue).put("float_val", configuredSettingValue).build()), equalTo(configuredSettingValue) ); There was a problem hiding this comment.
I think it is, but my naming is not great.
i.e. defaultSetting (the default for float_val.default) != configuredDefault (the configured value for float_val.default != configuredSetting (the configured value for float_val). I'll fix the naming up to make that clearer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Broken out of #126091