Esql - Fix lucene push down behavior when a range contains nanos and millis #125595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
not-napoleon added >bug auto-backport 
elasticsearchmachine added the Team:Analytics 
| Pinging @elastic/es-analytical-engine (Team:Analytics) |
| Hi @not-napoleon, I've created a changelog YAML for you. |
not-napoleon added a commit to not-napoleon/elasticsearch that referenced this pull request Mar 25, 2025
…millis (elastic#125595) Follow up to elastic#125345. If the query contained both a nanos and a millis comparison, we were formatting the dates incorrectly for the lucene push down. This PR adds a test and a fix for that case. --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
not-napoleon added a commit to not-napoleon/elasticsearch that referenced this pull request Mar 25, 2025
…millis (elastic#125595) Follow up to elastic#125345. If the query contained both a nanos and a millis comparison, we were formatting the dates incorrectly for the lucene push down. This PR adds a test and a fix for that case. --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
not-napoleon added a commit to not-napoleon/elasticsearch that referenced this pull request Mar 25, 2025
…millis (elastic#125595) Follow up to elastic#125345. If the query contained both a nanos and a millis comparison, we were formatting the dates incorrectly for the lucene push down. This PR adds a test and a fix for that case. --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
elasticsearchmachine pushed a commit that referenced this pull request Mar 25, 2025
…millis (#125595) (#125617) Follow up to #125345. If the query contained both a nanos and a millis comparison, we were formatting the dates incorrectly for the lucene push down. This PR adds a test and a fix for that case. --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
elasticsearchmachine pushed a commit that referenced this pull request Mar 25, 2025
…millis (#125595) (#125618) Follow up to #125345. If the query contained both a nanos and a millis comparison, we were formatting the dates incorrectly for the lucene push down. This PR adds a test and a fix for that case. --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
elasticsearchmachine pushed a commit that referenced this pull request Mar 25, 2025
…millis (#125595) (#125619) Follow up to #125345. If the query contained both a nanos and a millis comparison, we were formatting the dates incorrectly for the lucene push down. This PR adds a test and a fix for that case. --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
omricohenn pushed a commit to omricohenn/elasticsearch that referenced this pull request Mar 28, 2025
…millis (elastic#125595) Follow up to elastic#125345. If the query contained both a nanos and a millis comparison, we were formatting the dates incorrectly for the lucene push down. This PR adds a test and a fix for that case. --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
not-napoleon added a commit that referenced this pull request Mar 31, 2025
In #125595 I accidentally left some logging at WARN level; this PR corrects that to TRACE.
not-napoleon added a commit to not-napoleon/elasticsearch that referenced this pull request Mar 31, 2025
In elastic#125595 I accidentally left some logging at WARN level; this PR corrects that to TRACE.
not-napoleon added a commit to not-napoleon/elasticsearch that referenced this pull request Mar 31, 2025
In elastic#125595 I accidentally left some logging at WARN level; this PR corrects that to TRACE.
not-napoleon added a commit to not-napoleon/elasticsearch that referenced this pull request Mar 31, 2025
In elastic#125595 I accidentally left some logging at WARN level; this PR corrects that to TRACE.
elasticsearchmachine pushed a commit that referenced this pull request Mar 31, 2025
elasticsearchmachine pushed a commit that referenced this pull request Mar 31, 2025
elasticsearchmachine pushed a commit that referenced this pull request Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Follow up to #125345. If the query contained both a nanos and a millis comparison, we were formatting the dates incorrectly for the lucene push down. This PR adds a test and a fix for that case.