Fix AlibabaCloudSearchCompletionAction not accepting ChatCompletionInputs #125023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dan-rubinstein added :ml 
| Hi @dan-rubinstein, I've created a changelog YAML for you. |
| Pinging @elastic/ml-core (Team:ML) |
jonathan-buttner approved these changes Mar 17, 2025
dan-rubinstein added the auto-backport jonathan-buttner approved these changes Mar 20, 2025
💔 Backport failed
You can use sqren/backport to manually backport by running |
afoucret pushed a commit to afoucret/elasticsearch that referenced this pull request Mar 21, 2025
…puts (elastic#125023) * Fix AlibabaCloudSearchCompletionAction not accepting ChatCompletionInputs * Update docs/changelog/125023.yaml * Fix unit tests
dan-rubinstein added a commit to dan-rubinstein/elasticsearch that referenced this pull request Mar 21, 2025
…puts (elastic#125023) * Fix AlibabaCloudSearchCompletionAction not accepting ChatCompletionInputs * Update docs/changelog/125023.yaml * Fix unit tests
dan-rubinstein added a commit to dan-rubinstein/elasticsearch that referenced this pull request Mar 21, 2025
…puts (elastic#125023) * Fix AlibabaCloudSearchCompletionAction not accepting ChatCompletionInputs * Update docs/changelog/125023.yaml * Fix unit tests
smalyshev pushed a commit to smalyshev/elasticsearch that referenced this pull request Mar 21, 2025
…puts (elastic#125023) * Fix AlibabaCloudSearchCompletionAction not accepting ChatCompletionInputs * Update docs/changelog/125023.yaml * Fix unit tests
dan-rubinstein added a commit that referenced this pull request Mar 24, 2025
…tionInputs (#125023) (#125332) * Fix AlibabaCloudSearchCompletionAction not accepting ChatCompletionInputs (#125023) * Fix AlibabaCloudSearchCompletionAction not accepting ChatCompletionInputs * Update docs/changelog/125023.yaml * Fix unit tests * Fixing unit test import --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
omricohenn pushed a commit to omricohenn/elasticsearch that referenced this pull request Mar 28, 2025
…puts (elastic#125023) * Fix AlibabaCloudSearchCompletionAction not accepting ChatCompletionInputs * Update docs/changelog/125023.yaml * Fix unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
In a previous change we added the
ChatCompletionInputsforcompletionandchat_completiontask types. As part of these changes we updated the InferenceService class to always generateChatCompletionInputsfor these task types but did not update the alibaba completion action to accept these new input types. As such, Alibaba completion endpoints currently can not make any calls as they all expectDocumentsOnlyInputsbut receiveChatCompletionInputs. This change updates the action to expectChatCompletionInputsand adds tests to catch these types of changes in the future.Testing