Fix EQL double invoking listener #124918
Merged
Fix EQL double invoking listener #124918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
We need to break out early here, otherwise we double resolve the listener in the following code potentially.
elasticsearchmachine added Team:Analytics 
| Pinging @elastic/es-analytical-engine (Team:Analytics) |
| Hi @original-brownbear, I've created a changelog YAML for you. |
luigidellaquila approved these changes Mar 17, 2025
| This will also need a backport to 8.18, 8.19 and 9.0, I'm adding the appropriate labels |
luigidellaquila added v9.0.0 v8.18.0 v8.19.0 auto-backport 
| Thanks Luigi! |
This was referenced Mar 17, 2025
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Mar 17, 2025
We need to break out early here, otherwise we double resolve the listener in the following code potentially.
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Mar 17, 2025
We need to break out early here, otherwise we double resolve the listener in the following code potentially.
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Mar 17, 2025
We need to break out early here, otherwise we double resolve the listener in the following code potentially.
elasticsearchmachine pushed a commit that referenced this pull request Mar 17, 2025
elasticsearchmachine pushed a commit that referenced this pull request Mar 17, 2025
omricohenn pushed a commit to omricohenn/elasticsearch that referenced this pull request Mar 28, 2025
We need to break out early here, otherwise we double resolve the listener in the following code potentially.
elasticsearchmachine pushed a commit that referenced this pull request Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We need to break out early here, otherwise we double resolve the listener in the following code potentially.
More of a suggestion, I don't know enough about this code to write a reproducer but this seemed like the obvious spot for the double resolve.