Skip to content

Throw exception for unknown token in RestIndexPutAliasAction #124708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 29, 2025
Merged

Throw exception for unknown token in RestIndexPutAliasAction #124708

merged 15 commits into from
Apr 29, 2025

Conversation

mushao999
Copy link
Contributor

This PR throws IllegalArgumentException in RestIndexPutAliasAction to aovid slience Swallowing unsupport token
@elasticsearchmachine elasticsearchmachine added external-contributor Pull request authored by a developer outside the Elasticsearch team v9.1.0 needs:triage Requires assignment of a team area label labels Mar 13, 2025
@mushao999 mushao999 force-pushed the optimize/createIndexWithAlias branch from 6a44417 to 406ebda Compare March 13, 2025 12:17
@fressi-elastic fressi-elastic added the :Data Management/Indices APIs APIs to create and manage indices and templates label Mar 14, 2025
@elasticsearchmachine elasticsearchmachine added Team:Data Management Meta label for data/management team and removed needs:triage Requires assignment of a team area label labels Mar 14, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)
@mushao999
Copy link
Contributor Author

ping @fressi-elastic
@dakrone dakrone self-assigned this Mar 21, 2025
@dakrone dakrone added the >bug label Mar 21, 2025
dakrone
dakrone approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@dakrone
Copy link
Member

dakrone commented Mar 21, 2025

buildkit test this
@mushao999
Copy link
Contributor Author

yamlRestTest added @dakrone
@dakrone
Copy link
Member

dakrone commented Mar 24, 2025

buildkite test this
@mushao999
Copy link
Contributor Author

mushao999 commented Mar 24, 2025 •
edited
Loading

Our changes helped us find two mis-use of _alias API in IT, I'v fixed them with the new commit. @dakrone
@mushao999
Copy link
Contributor Author

ping @dakrone
@dakrone
Copy link
Member

dakrone commented Apr 10, 2025

buildkite test this
dakrone
dakrone approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
@dakrone dakrone added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Apr 10, 2025
@mushao999
Copy link
Contributor Author

@dakrone As we changed the behavior of RestIndexPutAliasAction, some of the BWC tests could not pass. So I added the cluster feature for bwc tests. Could you please enable the auto testing for this PR , and I will fix the potential test failure and conflicts（conflict with #124737 maybe）
@dakrone
Copy link
Member

dakrone commented Apr 28, 2025

buildkite test this
@dakrone
Copy link
Member

dakrone commented Apr 28, 2025

@mushao999 thanks for resolving that, it looks like the CI passed, it just conflicts with the other PR (#124737), do you want to fix this one and then I can merge it in?
@mushao999
Copy link
Contributor Author

mushao999 commented Apr 28, 2025 •
edited
Loading

@mushao999 thanks for resolving that, it looks like the CI passed, it just conflicts with the other PR (#124737), do you want to fix this one and then I can merge it in?

Conflicts resolved @dakrone
@dakrone
Copy link
Member

dakrone commented Apr 29, 2025

buildkite test this
@elasticsearchmachine elasticsearchmachine merged commit feb44c5 into elastic:main Apr 29, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >bug :Data Management/Indices APIs APIs to create and manage indices and templates external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Data Management Meta label for data/management team v9.1.0

4 participants

@mushao999 @elasticsearchmachine @dakrone @fressi-elastic