Fix geoip databases index access after system feature migration (take 3) #124604
+43 −22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
We need to cover all the values for expand_wildcards, not just the default.
joegallo added >bug :Data Management/Ingest Node 
| Pinging @elastic/es-data-management (Team:Data Management) |
| Hi @joegallo, I've created a changelog YAML for you. |
💔 Backport failed
You can use sqren/backport to manually backport by running |
joegallo added a commit to joegallo/elasticsearch that referenced this pull request Mar 12, 2025
joegallo added a commit to joegallo/elasticsearch that referenced this pull request Mar 12, 2025
joegallo added a commit to joegallo/elasticsearch that referenced this pull request Mar 12, 2025
This was referenced Mar 12, 2025
elasticsearchmachine pushed a commit that referenced this pull request Mar 12, 2025
elasticsearchmachine pushed a commit that referenced this pull request Mar 12, 2025
elasticsearchmachine pushed a commit that referenced this pull request Mar 12, 2025
albertzaharovits pushed a commit to albertzaharovits/elasticsearch that referenced this pull request Mar 13, 2025
jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is a follow up to #121196 and #122938.
The first PR fixed the
GET *case, but broke theGET _data_stream/*case. The second PR fixed theGET _data_stream/*case but it turns out it only fixed it for some values of theexpand_wildcardsparameter.This PR expands the integration test to walk the various options of the
expand_wildcardsparameter and try all of them, and then fixes the broken cases by changing our index resolution code ever so slightly.