IngestDocument readability improvements #124322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
That is, for all these instanceof checks, have the order be null/Map/List/(else?).
These are generic-ed off in the other instanceof checks, these ones don't need to be different.
joegallo added :Data Management/Ingest Node joegallo added the auto-backport 
| Pinging @elastic/es-data-management (Team:Data Management) |
masseyke approved these changes Mar 7, 2025
This was referenced Mar 8, 2025
joegallo added a commit to joegallo/elasticsearch that referenced this pull request Mar 8, 2025
joegallo added a commit to joegallo/elasticsearch that referenced this pull request Mar 8, 2025
elasticsearchmachine pushed a commit that referenced this pull request Mar 8, 2025
elasticsearchmachine pushed a commit that referenced this pull request Mar 8, 2025
elasticsearchmachine pushed a commit that referenced this pull request Mar 8, 2025
georgewallace pushed a commit to georgewallace/elasticsearch that referenced this pull request Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I've been in this code a lot recently. The String constructions really don't indent very well and it finally hurt my soul enough to do something about it. There's a small handful of additional trivial improvements that I made while I was there, but nothing that should have any effect on the behavior or performance of the system.
There are further commits beyond this on my machine that will very much have an effect on the behavior and performance of the system, but this PR is really just refactoring.