[Inference API] Fix output stream ordering in InferenceActionProxy #124225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
timgrein added :ml 
| Pinging @elastic/ml-core (Team:ML) |
| Hi @timgrein, I've created a changelog YAML for you. |
jonathan-buttner approved these changes Mar 6, 2025
This was referenced Mar 6, 2025
timgrein added a commit to timgrein/elasticsearch that referenced this pull request Mar 6, 2025
timgrein added a commit to timgrein/elasticsearch that referenced this pull request Mar 6, 2025
elasticsearchmachine pushed a commit that referenced this pull request Mar 6, 2025
georgewallace pushed a commit to georgewallace/elasticsearch that referenced this pull request Mar 11, 2025
elasticsearchmachine pushed a commit that referenced this pull request Mar 11, 2025
costin pushed a commit to costin/elasticsearch that referenced this pull request Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
While working on propagating product use case I've noticed an ordering issue in the stream output of
InferenceActionProxy:taskTypewas written afterinferenceEntityId, but the reading side expects it the other way around. I assume we need/should backport this?