Introduce allow_partial_results setting in ES|QL #122890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dnhatn force-pushed the default-partial-results-rest branch 9 times, most recently from 311e8b0 to ffc7f8f Compare dnhatn force-pushed the default-partial-results-rest branch 2 times, most recently from 1d1bb2b to 25837c5 Compare dnhatn changed the title 
dnhatn force-pushed the default-partial-results-rest branch from 25837c5 to e8873ce Compare dnhatn changed the title 
| Hi @dnhatn, I've created a changelog YAML for you. |
10 tasks
| Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine added the Team:Analytics 
smalyshev approved these changes Mar 5, 2025
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/RequestXContent.java Show resolved Hide resolved
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlQueryRequest.java Show resolved Hide resolved
… testDuplicatePrunedPaths elastic#124006
* Remove duplicate exclusive paths * Normalize paths in tests to support Windows * Remove withMode
…ntYamlTestSuiteIT test {yaml=search.vectors/41_knn_search_bbq_hnsw/Vector rescoring has same scoring as exact search for kNN section} elastic#124052 …arty_deployment/Test start deployment fails while model download in progress} elastic#120814
Use the same exception class in more places where single lookup fails due to the existence of multiple projects. This allows the exception to be handled similarly, e.g. ignored in ClusterApplierService#callClusterStateListener
dnhatn added the auto-backport dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Mar 5, 2025
This change introduces a cluster setting `esql.query.allow_partial_results` that allows enabling or disabling allow_partial_results in ES|QL at the cluster-wide level. Initially, this setting defaults to false, but it will be switched to true soon. The reason for not changing the default in this PR is that it requires adjusting many tests, which would make the PR too large. Instead, we will adjust the tests incrementally and switch the default when the tests are ready. This cluster setting is useful for falling back to the previous behavior (i.e., disabling allow_partial_results) if users upgrade to the new version and haven't updated their queries. Also, the default setting can be overridden on a per-request basis via a URL parameter (allow_partial_results) (changed from request body to URL parameter to conform to the proposal). Relates elastic#122802
💚 Backport successful
|
elasticsearchmachine pushed a commit that referenced this pull request Mar 5, 2025
This change introduces a cluster setting `esql.query.allow_partial_results` that allows enabling or disabling allow_partial_results in ES|QL at the cluster-wide level. Initially, this setting defaults to false, but it will be switched to true soon. The reason for not changing the default in this PR is that it requires adjusting many tests, which would make the PR too large. Instead, we will adjust the tests incrementally and switch the default when the tests are ready. This cluster setting is useful for falling back to the previous behavior (i.e., disabling allow_partial_results) if users upgrade to the new version and haven't updated their queries. Also, the default setting can be overridden on a per-request basis via a URL parameter (allow_partial_results) (changed from request body to URL parameter to conform to the proposal). Relates #122802
georgewallace pushed a commit to georgewallace/elasticsearch that referenced this pull request Mar 11, 2025
This change introduces a cluster setting `esql.query.allow_partial_results` that allows enabling or disabling allow_partial_results in ES|QL at the cluster-wide level. Initially, this setting defaults to false, but it will be switched to true soon. The reason for not changing the default in this PR is that it requires adjusting many tests, which would make the PR too large. Instead, we will adjust the tests incrementally and switch the default when the tests are ready. This cluster setting is useful for falling back to the previous behavior (i.e., disabling allow_partial_results) if users upgrade to the new version and haven't updated their queries. Also, the default setting can be overridden on a per-request basis via a URL parameter (allow_partial_results) (changed from request body to URL parameter to conform to the proposal). Relates elastic#122802
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This change introduces a cluster setting
esql.query.allow_partial_resultsthat allows enabling or disabling allow_partial_results in ES|QL at the cluster-wide level. Initially, this setting defaults to false, but it will be switched to true soon. The reason for not changing the default in this PR is that it requires adjusting many tests, which would make the PR too large. Instead, we will adjust the tests incrementally and switch the default when the tests are ready. This cluster setting is useful for falling back to the previous behavior (i.e., disabling allow_partial_results) if users upgrade to the new version and haven't updated their queries.Also, the default setting can be overridden on a per-request basis via a URL parameter (
allow_partial_results) (changed from request body to URL parameter to conform to the proposal).Relates #122802