Unmute testSuggestTimeoutWithPartialResults #122757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This test uncovered an issue in the suggest timeout handling logic. Addressed with elastic#122675 in 9.0. The test can be unmuted.
javanna added >test 
| Pinging @elastic/es-search-relevance (Team:Search Relevance) |
elasticsearchmachine added the Team:Search Relevance javanna deleted the backport/9.0/re-enable_test_suggest_partial_results branch Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This test uncovered an issue in the suggest timeout handling logic. Addressed with #122675 in 9.0. The test can be unmuted. It got muted due to failures happened right before the merge was merged.