Add basic implementations of float-byte script comparisons #122381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
thecoop commented Feb 12, 2025
| | ||
| @Override | ||
| public float ipFloatByte(float[] q, byte[] d) { | ||
| return DefaultESVectorUtilSupport.ipFloatByteImpl(q, d); |
There was a problem hiding this comment.
Panama implementation can be added as a separate PR
| We could do this the other way too - add implementations of |
| Hi @thecoop, I've created a changelog YAML for you. |
elasticsearchmachine added the Team:Search Relevance | Pinging @elastic/es-search-relevance (Team:Search Relevance) |
| I think this looks good as a first step. Could you add some tests here: modules/lang-painless/src/yamlRestTest/resources/rest-api-spec/test/painless/145_dense_vector_byte_basic.yml Obviously, a component will need to be added. But it will help increase our coverage for free. |
benwtrent reviewed Feb 12, 2025
...nless/src/yamlRestTest/resources/rest-api-spec/test/painless/145_dense_vector_byte_basic.yml Outdated Show resolved Hide resolved
| More heterogenous methods can be introduced in later PRs using this infrastructure |
benwtrent reviewed Feb 21, 2025
server/src/main/java/org/elasticsearch/script/VectorScoreScriptUtils.java Show resolved Hide resolved
server/src/main/java/org/elasticsearch/script/VectorScoreScriptUtils.java Outdated Show resolved Hide resolved
thecoop force-pushed the float-byte-script-comparisons branch from 4374e6c to 1d99668 Compare benwtrent reviewed Feb 27, 2025
server/src/main/java/org/elasticsearch/script/VectorScoreScriptUtils.java Outdated Show resolved Hide resolved
server/src/main/java/org/elasticsearch/script/VectorScoreScriptUtils.java Show resolved Hide resolved
server/src/main/java/org/elasticsearch/script/VectorScoreScriptUtils.java Show resolved Hide resolved
server/src/main/java/org/elasticsearch/script/VectorScoreScriptUtils.java Outdated Show resolved Hide resolved
❤️ Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add comparisons of
float[]queries withbyte[]vectorsThis fixes #117274