- Notifications
You must be signed in to change notification settings - Fork 25.7k
[Transform] Delete Alias Write Index #122074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When the Transform is configured to write to an alias, specifying `DELETE _transform/<id>?delete_dest_index` will follow the alias to the concrete destination index. Fix elastic#121913
| Documentation preview: |
| Warning It looks like this PR modifies one or more |
| Hi @prwhelan, I've created a changelog YAML for you. |
| Warning It looks like this PR modifies one or more |
| Warning It looks like this PR modifies one or more |
| Warning It looks like this PR modifies one or more |
| Pinging @elastic/ml-core (Team:ML) |
przemekwitek left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
docs/changelog/122074.yaml Outdated
| @@ -0,0 +1,6 @@ | |||
| pr: 122074 | |||
| summary: Delete Alias Write Index | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make the summary explain what is the visible impact of this PR for the customer.
Maybe sth like "Fix Delete API with delete_dest_index parameter when the destination index alias is used"?
...m/src/main/java/org/elasticsearch/xpack/transform/action/TransportDeleteTransformAction.java Outdated Show resolved Hide resolved
...m/src/main/java/org/elasticsearch/xpack/transform/action/TransportDeleteTransformAction.java Outdated Show resolved Hide resolved
Co-authored-by: Przemysław Witek <przemyslaw.witek@elastic.co>
przemekwitek left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
When the Transform is configured to write to an alias, specifying `DELETE _transform/<id>?delete_dest_index` will follow the alias to the concrete destination index. Fix elastic#121913 Co-authored-by: Przemysław Witek <przemyslaw.witek@elastic.co>
When the Transform is configured to write to an alias, specifying `DELETE _transform/<id>?delete_dest_index` will follow the alias to the concrete destination index. Fix elastic#121913 Co-authored-by: Przemysław Witek <przemyslaw.witek@elastic.co>
When the Transform is configured to write to an alias, specifying `DELETE _transform/<id>?delete_dest_index` will follow the alias to the concrete destination index. Fix elastic#121913 Co-authored-by: Przemysław Witek <przemyslaw.witek@elastic.co>
When the Transform is configured to write to an alias, specifying `DELETE _transform/<id>?delete_dest_index` will follow the alias to the concrete destination index. Fix #121913 Co-authored-by: Przemysław Witek <przemyslaw.witek@elastic.co>
* [Transform] Delete Alias Write Index (#122074) When the Transform is configured to write to an alias, specifying `DELETE _transform/<id>?delete_dest_index` will follow the alias to the concrete destination index. Fix #121913 Co-authored-by: Przemysław Witek <przemyslaw.witek@elastic.co> * Update for 8.x api --------- Co-authored-by: Przemysław Witek <przemyslaw.witek@elastic.co>
* [Transform] Delete Alias Write Index (#122074) When the Transform is configured to write to an alias, specifying `DELETE _transform/<id>?delete_dest_index` will follow the alias to the concrete destination index. Fix #121913 Co-authored-by: Przemysław Witek <przemyslaw.witek@elastic.co> * Update for 8.x api --------- Co-authored-by: Przemysław Witek <przemyslaw.witek@elastic.co>
When the Transform is configured to write to an alias, specifying
DELETE _transform/<id>?delete_dest_indexwill follow the alias to the concrete destination index.Fix #121913