Skip to content

Conversation

idegtiarenko
Copy link
Contributor

@idegtiarenko idegtiarenko commented Feb 5, 2025

This change refactors aggregation implementers by:

  • removing unused methods in Types and replacing duplicated code with a common implementation
  • replacing type derivation with a corresponding aggState (that encapsulates information related to SingleState and GroupingState) and aggParam (encapsulates parameter to the aggregation function) classes.

This refactoring is intended to:

  • make it simpler to add more than a single agg parameter in the future (for use cases such as first(column, @timestamp) and topN(column, count, ASC/DECK, @timestamp)
  • reduce Method dependencies to make it easier to use requireMethod to spell expected method signatures.

This does not cause any changes in the generated code.

@idegtiarenko idegtiarenko added >refactoring Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) :Analytics/ES|QL AKA ESQL v9.1.0 labels Feb 5, 2025
@idegtiarenko idegtiarenko requested a review from nik9000 February 5, 2025 20:46
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

@idegtiarenko idegtiarenko added auto-backport Automatically create backport pull requests when merged v9.0.0 v8.18.0 v8.19.0 and removed v8.18.0 labels Feb 6, 2025
@idegtiarenko idegtiarenko merged commit 17d25ad into elastic:main Feb 6, 2025
17 checks passed
@idegtiarenko idegtiarenko deleted the cleanup branch February 6, 2025 08:04
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
9.0 Commit could not be cherrypicked due to conflicts
8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 121818

@idegtiarenko
Copy link
Contributor Author

The backport is failing as both 8.x and 9.0 do not have following back-ported yet: #119889

idegtiarenko added a commit to idegtiarenko/elasticsearch that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged backport pending >refactoring Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.19.0 v9.0.0 v9.1.0

3 participants