ReindexDataStreamIndex bug in assertion caused by reference equality #121325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
elasticsearchmachine added needs:triage 
masseyke approved these changes Jan 30, 2025
parkertimmins added >bug :Data Management/Data streams elasticsearchmachine added the Team:Data Management 
| Pinging @elastic/es-data-management (Team:Data Management) |
| Hi @parkertimmins, I've created a changelog YAML for you. |
smalyshev pushed a commit to smalyshev/elasticsearch that referenced this pull request Jan 30, 2025
…lastic#121325) Assertion was using reference equality on two boxed longs. So assertion could produce false positives. Change to Objects.equals to check value and avoid null check.
saikatsarkar056 pushed a commit to saikatsarkar056/elasticsearch that referenced this pull request Jan 31, 2025
…lastic#121325) Assertion was using reference equality on two boxed longs. So assertion could produce false positives. Change to Objects.equals to check value and avoid null check.
bpintea pushed a commit to bpintea/elasticsearch that referenced this pull request Jan 31, 2025
…lastic#121325) Assertion was using reference equality on two boxed longs. So assertion could produce false positives. Change to Objects.equals to check value and avoid null check.
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
parkertimmins added a commit to parkertimmins/elasticsearch that referenced this pull request Jan 31, 2025
…lastic#121325) Assertion was using reference equality on two boxed longs. So assertion could produce false positives. Change to Objects.equals to check value and avoid null check. (cherry picked from commit eeb745c)
parkertimmins added a commit to parkertimmins/elasticsearch that referenced this pull request Jan 31, 2025
…lastic#121325) Assertion was using reference equality on two boxed longs. So assertion could produce false positives. Change to Objects.equals to check value and avoid null check. (cherry picked from commit eeb745c)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
parkertimmins added a commit to parkertimmins/elasticsearch that referenced this pull request Feb 3, 2025
…lastic#121325) Assertion was using reference equality on two boxed longs. So assertion could produce false positives. Change to Objects.equals to check value and avoid null check. (cherry picked from commit eeb745c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Assertion was using reference equality on two boxed longs. So assertion could produce false positives. Change to Objects.equals to check value and avoid null check.