Refresh source index before reindexing data stream index #120752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
parkertimmins added >bug :Data Management/Data streams 
elasticsearchmachine added the Team:Data Management 
Collaborator
| Pinging @elastic/es-data-management (Team:Data Management) |
Collaborator
| Hi @parkertimmins, I've created a changelog YAML for you. |
masseyke approved these changes Jan 23, 2025
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
Contributor Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
parkertimmins added a commit to parkertimmins/elasticsearch that referenced this pull request Jan 24, 2025
) Add step to the ReindexDatastreamIndexAction which refreshes the source index after setting it to read-only but before calling reindex. Without doing a refresh it is possible for docs from the source index to be missing from the destination index. This happens because the docs arrived before the source index is set to read-only, but because the index hasn't refreshed, the reindex action cannot see these updates. (cherry picked from commit 484a950) # Conflicts: # muted-tests.yml
elasticsearchmachine pushed a commit that referenced this pull request Jan 24, 2025
…120808) Add step to the ReindexDatastreamIndexAction which refreshes the source index after setting it to read-only but before calling reindex. Without doing a refresh it is possible for docs from the source index to be missing from the destination index. This happens because the docs arrived before the source index is set to read-only, but because the index hasn't refreshed, the reindex action cannot see these updates. (cherry picked from commit 484a950) # Conflicts: # muted-tests.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add step to the ReindexDatastreamIndexAction which refreshes the source index after setting it to read-only but before calling reindex. Without doing a refresh it is possible for docs from the source index to be missing from the destination index. This happens because the docs arrived before the source index is set to read-only, but because the index hasn't refreshed, the reindex action cannot see these updates.
As part of this change, removed source index refreshes from test as these were hiding the issue.
Fixes #120314