Increase field limit for OTel metrics to 10 000 #120591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The default field limit of 1000 seems undersized, especially for the default data stream. Each distinct attribute/dimension name and metric name count towards that limit
felixbarny added >enhancement auto-backport 
elasticsearchmachine added Team:StorageEngine external-contributor 
Collaborator
| Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Collaborator
| Hi @felixbarny, I've created a changelog YAML for you. |
gregkalapos approved these changes Jan 22, 2025
carsonip approved these changes Jan 22, 2025
carsonip reviewed Jan 22, 2025
| # by xpack-plugin otel-data. This must be increased whenever an existing template is | ||
| # changed, in order for it to be updated on Elasticsearch upgrade. | ||
| version: 7 | ||
| version: 8 |
Member
There was a problem hiding this comment.
Collaborator
💚 Backport successful
|
felixbarny added a commit that referenced this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The default field limit of 1000 seems undersized, especially for the default data stream. Each distinct attribute/dimension name and metric name count towards that limit.
For comparison, this makes us use the same field limit for OTel that we currently have for the prometheus integration.