EQL: set allow_partial_search_results=true by default #120267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Documentation preview: |
luigidellaquila added >enhancement >breaking :Analytics/EQL 
elasticsearchmachine added the Team:Analytics 
| Pinging @elastic/es-analytical-engine (Team:Analytics) |
| Hi @luigidellaquila, I've created a changelog YAML for you. Note that since this PR is labelled |
| Hi @luigidellaquila, I've updated the changelog YAML for you. Note that since this PR is labelled |
astefan approved these changes Jan 20, 2025
docs/changelog/120267.yaml Outdated
| area: REST API | ||
| details: | ||
| Before this change, in case of shard failures, EQL queries always returned an error. | ||
| With this change,they will keep running and will return partial results. |
There was a problem hiding this comment.
Suggested change
| With this change,they will keep running and will return partial results. | |
| With this change, they will keep running and will return partial results. |
💚 Backport successful
|
luigidellaquila added a commit to luigidellaquila/elasticsearch that referenced this pull request Jan 27, 2025
luigidellaquila added a commit that referenced this pull request Jan 29, 2025
| @luigidellaquila is this PR relevant to the serverless changelog? [FYI this question is based on 9.0 breaking changes] |
| @leemthompo it is a breaking change and it also applies to Serverless, so I guess it's relevant |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Change EQL behavior to allow partial search results by default, in case of shard failures.
The old defaults (ie. let the query fail in case of shard failures) can be restored by setting Cluster Setting
xpack.eql.default_allow_partial_results=falseFixes: #120188