Skip to content

Ignore closed indices for reindex #120244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 21, 2025
Merged

Ignore closed indices for reindex #120244

merged 8 commits into from
Jan 21, 2025

Conversation

masseyke
Copy link
Member

This makes it so that the deprecation info API no longer reports that closed indices need to be reindexed.
@masseyke masseyke added >enhancement :Data Management/Data streams Data streams and their lifecycles auto-backport Automatically create backport pull requests when merged v8.18.0 labels Jan 15, 2025
@elasticsearchmachine
Copy link
Collaborator

Hi @masseyke, I've created a changelog YAML for you.
@lukewhiting
Copy link
Contributor

Given the predicate is shared with the deprecation info API, it might be an idea to update org.elasticsearch.xpack.deprecation.DataStreamDeprecationChecksTests to also be aware of closed indices, and also possibly org.elasticsearch.xpack.deprecation.IndexDeprecationChecksTests too.
@jloleysens
Copy link
Contributor

If a 7.x index is closed and ignored during 8.last, then re-opened in 9, will it automatically be made "read-only" and thus compatible? Or will it not be openable?
parkertimmins
parkertimmins approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@parkertimmins parkertimmins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
@masseyke
Copy link
Member Author

If a 7.x index is closed and ignored during 8.last, then re-opened in 9, will it automatically be made "read-only" and thus compatible? Or will it not be openable?

My understanding is that it will automatically be made read-only.
@masseyke masseyke marked this pull request as ready for review January 17, 2025 19:47
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Jan 17, 2025
lukewhiting
lukewhiting approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@lukewhiting lukewhiting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻
@masseyke masseyke merged commit bf701c9 into elastic:main Jan 21, 2025
16 checks passed
@masseyke masseyke deleted the reindex-data-streams-ignore-closed-indices branch January 21, 2025 15:26
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 120244
masseyke added a commit to masseyke/elasticsearch that referenced this pull request Jan 21, 2025
@masseyke
Ignore closed indices for reindex (elastic#120244)
06bf21f
elasticsearchmachine pushed a commit that referenced this pull request Jan 21, 2025
@masseyke
Ignore closed indices for reindex (#120244) (#120562)
43df7d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged :Data Management/Data streams Data streams and their lifecycles >enhancement Team:Data Management Meta label for data/management team v8.18.0 v9.0.0

5 participants

@masseyke @elasticsearchmachine @lukewhiting @jloleysens @parkertimmins