Skip to content

Conversation

ioanatia
Copy link
Contributor

@ioanatia ioanatia commented Jan 7, 2025

Enables full text functions to be translated to query builders on the coordinator.
The functionality was added in #118676
This change does not enable semantic search in ES|QL.
While this is a requirement for semantic search, this is a general functionality that we can benefit all search functions.
We initially had a conservative approach and added this functionality behind a snapshot, reusing the SEMANTIC_TEXT_TYPE capability, but we can take it out of snapshot irrespective of semantic search.

@ioanatia ioanatia marked this pull request as ready for review January 7, 2025 16:26
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jan 7, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Copy link
Contributor

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@fang-xing-esql fang-xing-esql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@ioanatia ioanatia added auto-backport Automatically create backport pull requests when merged v8.18.0 labels Jan 9, 2025
@ioanatia ioanatia merged commit 4122144 into elastic:main Jan 9, 2025
16 checks passed
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.x
ioanatia added a commit to ioanatia/elasticsearch that referenced this pull request Jan 9, 2025
* Enable query rewrites on the coordinator for ESQL * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
@ioanatia ioanatia mentioned this pull request Jan 9, 2025
16 tasks
elasticsearchmachine pushed a commit that referenced this pull request Jan 9, 2025
* Enable query rewrites on the coordinator for ESQL * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co> Co-authored-by: Felix Barnsteiner <felixbarny@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.18.0 v9.0.0

5 participants