Http stream activity tracker and exceptions handling #119564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
elasticsearchmachine added the needs:triage 
mhl-b added >enhancement :Distributed Coordination/Network 
| Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
| Hi @mhl-b, I've created a changelog YAML for you. |
mhl-b commented Jan 6, 2025
| public void close() throws Exception { | ||
| safeGet(clientChannel.close()); | ||
| safeGet(clientBootstrap.config().group().shutdownGracefully()); | ||
| safeGet(clientBootstrap.config().group().shutdownGracefully(0, 0, TimeUnit.SECONDS)); |
There was a problem hiding this comment.
A speedup for integ test suite.
nicktindall reviewed Jan 6, 2025
...ort-netty4/src/test/java/org/elasticsearch/http/netty4/Netty4HttpRequestBodyStreamTests.java Show resolved Hide resolved
nicktindall approved these changes Jan 6, 2025
| Thanks Nick! |
mhl-b added a commit to mhl-b/elasticsearch that referenced this pull request Jan 8, 2025
mhl-b added a commit to mhl-b/elasticsearch that referenced this pull request Jan 8, 2025
elasticsearchmachine pushed a commit that referenced this pull request Jan 8, 2025
| @mhl-b according to this PR's labels, it should not have a changelog YAML, but I can't delete it because it is closed. Please either delete the changelog from the appropriate branch yourself, or adjust the labels. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Pulling larger PR apart #117787.
Add HTTP body stream activity tracker when chunk is buffered. Also catch all (Throwable) exceptions when running ChunkConsumer in the channel event-loop. Some exceptions, for example OOM graceful shutdown, can slip through and never terminate stream and channel, making it hanging indefinitely. This causes issues during shutdown.