Skip to content

Conversation

PeteGillinElastic
Copy link
Member

@PeteGillinElastic PeteGillinElastic commented Dec 23, 2024

N.B. There is cleanup work we can do as a follow-up, but this is the main user-visible change.

@PeteGillinElastic PeteGillinElastic force-pushed the remove-freeze-unfreeze-9.0 branch 3 times, most recently from e75badb to 5d0c861 Compare January 3, 2025 13:09
@PeteGillinElastic PeteGillinElastic added >breaking :Data Management/Indices APIs APIs to create and manage indices and templates labels Jan 3, 2025
@elasticsearchmachine
Copy link
Collaborator

Hi @PeteGillinElastic, I've created a changelog YAML for you. Note that since this PR is labelled >breaking, you need to update the changelog YAML to fill out the extended information sections.

@PeteGillinElastic PeteGillinElastic force-pushed the remove-freeze-unfreeze-9.0 branch from f0b6d78 to 9dad9c1 Compare January 3, 2025 16:32
mattkime added a commit to elastic/kibana that referenced this pull request Jan 8, 2025
## Summary Remove code related to unfreezing indices since the functionality is being removed from v9 due to elastic/elasticsearch#119227
@PeteGillinElastic PeteGillinElastic force-pushed the remove-freeze-unfreeze-9.0 branch from 9dad9c1 to 7fc0815 Compare January 8, 2025 17:10
This adds a sentence to `redirects.asciidoc` explaining what frozen indices were - otherwise, everything will point to the message about the unfreeze API having gone away, which is not very helpful. Some cross-references are updated to point to this rather than to the notice about the removal of the unfreeze API.
@PeteGillinElastic PeteGillinElastic force-pushed the remove-freeze-unfreeze-9.0 branch from 7fc0815 to 8d7d3cb Compare January 10, 2025 12:51
@PeteGillinElastic PeteGillinElastic marked this pull request as ready for review January 10, 2025 14:12
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Jan 10, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left one comment

@@ -1,67 +0,0 @@
{
"indices.unfreeze":{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea how the clients spec handles removals, but we should maybe check there also after this is merged?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, good point. I believe that the change will get automatically mirrored to https://github.com/elastic/elasticsearch-specification/tree/main/specification/_json_spec. That may cause validation errors which I guess would be solved by also removing https://github.com/elastic/elasticsearch-specification/tree/main/specification/indices/unfreeze.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dakrone for this comment! Turns out the validation errors are breaking our sync, I removed this API manually in elastic/elasticsearch-specification#3552.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry about that @pquentin, I thought this was something we could do safely as a follow-up!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries I thought so too. We haven't removed an API in years and our tooling isn't ready for it :) Hopefully we will merge the two specs soon ™️

@PeteGillinElastic PeteGillinElastic enabled auto-merge (squash) January 14, 2025 09:33
@PeteGillinElastic PeteGillinElastic merged commit d85b90a into elastic:main Jan 14, 2025
16 checks passed
martijnvg pushed a commit to martijnvg/elasticsearch that referenced this pull request Jan 14, 2025
This adds a sentence to `redirects.asciidoc` explaining what frozen indices were - otherwise, everything will point to the message about the unfreeze API having gone away, which is not very helpful. Some cross-references are updated to point to this rather than to the notice about the removal of the unfreeze API. ES-9736 #comment Removed `_unfreeze` REST endpoint in elastic#119227
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
## Summary Remove code related to unfreezing indices since the functionality is being removed from v9 due to elastic/elasticsearch#119227
@leemthompo
Copy link
Contributor

@PeteGillinElastic is this PR relevant to the serverless changelog? [FYI this question is based on 9.0 breaking changes]

@PeteGillinElastic
Copy link
Member Author

@PeteGillinElastic is this PR relevant to the serverless changelog? [FYI this question is based on 9.0 breaking changes]

No, frozen indices were never a thing in serverless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>breaking :Data Management/Indices APIs APIs to create and manage indices and templates Team:Data Management Meta label for data/management team v9.0.0

5 participants