Clean up some older collections idioms in ILM #118508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
you can almost always just toList() instead.
by using the newer factory methods, which conserves precious characters.
joegallo added >non-issue :Data Management/ILM+SLM 
Collaborator
| Pinging @elastic/es-data-management (Team:Data Management) |
Contributor Author
| Related to #90883 |
masseyke approved these changes Dec 12, 2024
joegallo added a commit to joegallo/elasticsearch that referenced this pull request Dec 12, 2024
elasticsearchmachine pushed a commit that referenced this pull request Dec 12, 2024
maxhniebergall pushed a commit to maxhniebergall/elasticsearch that referenced this pull request Dec 16, 2024
maxhniebergall pushed a commit to maxhniebergall/elasticsearch that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I don't actually intend for anybody to review this character for character, but if you do then I'll award you a 🌟.
Similar to #118466, #118338, and #118488 -- this is just a cleanup PR since I'm in this code anyway. Also, this is the last one, I swear I'm going to stop.